cleanup: pass string as const reference from c/b/extension/api

cleanup: pass string as const reference from c/b/extension/api

BUG=367418
TEST=unit_tests --gtest_filter=FileSystemApiUnitTest.*

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=268060

[limasdf, 2014-05-02 04:57:17]

when you have time

[Devlin, 2014-05-02 15:34:15]

one small nit.

https://codereview.chromium.org/265703011/diff/1/chrome/browser/extensions/ap...
File chrome/browser/extensions/api/file_system/file_system_api_unittest.cc
(right):

https://codereview.chromium.org/265703011/diff/1/chrome/browser/extensions/ap...
chrome/browser/extensions/api/file_system/file_system_api_unittest.cc:29:
std::string mime_types,
why not also make the other two params const &?

https://codereview.chromium.org/265703011/diff/1/chrome/browser/extensions/ap...
chrome/browser/extensions/api/file_system/file_system_api_unittest.cc:102:
BuildAcceptOption(std::string(), std::string(), "jso,js")));
Yet another "while you're here" request. :)

Can you please replace all instances of "std::string()" in this file with
"base::EmptyString()"?  It saves us on the many constructions of new strings
that we don't need.  Admittedly, it's a unittest, so speed isn't as vital, but
it's a good practice.

[limasdf, 2014-05-02 16:26:45]

Thanks much for the view and nice suggestion! yay!

https://codereview.chromium.org/265703011/diff/1/chrome/browser/extensions/ap...
File chrome/browser/extensions/api/file_system/file_system_api_unittest.cc
(right):

https://codereview.chromium.org/265703011/diff/1/chrome/browser/extensions/ap...
chrome/browser/extensions/api/file_system/file_system_api_unittest.cc:29:
std::string mime_types,
On 2014/05/02 15:34:15, D Cronin wrote:
> why not also make the other two params const &?

Done. I dont know why-_- I didn't

https://codereview.chromium.org/265703011/diff/1/chrome/browser/extensions/ap...
chrome/browser/extensions/api/file_system/file_system_api_unittest.cc:102:
BuildAcceptOption(std::string(), std::string(), "jso,js")));
On 2014/05/02 15:34:15, D Cronin wrote:
> Yet another "while you're here" request. :)
> 
> Can you please replace all instances of "std::string()" in this file with
> "base::EmptyString()"?  It saves us on the many constructions of new strings
> that we don't need.  Admittedly, it's a unittest, so speed isn't as vital, but
> it's a good practice.

Done.

[limasdf, 2014-05-02 16:26:55]

ptal

[Devlin, 2014-05-02 16:33:58]

lgtm with one nit to cleanup before CQ :)

https://codereview.chromium.org/265703011/diff/10001/chrome/browser/extension...
File chrome/browser/extensions/api/file_system/file_system_api_unittest.cc
(right):

https://codereview.chromium.org/265703011/diff/10001/chrome/browser/extension...
chrome/browser/extensions/api/file_system/file_system_api_unittest.cc:6:
#include "base/strings/string_split.h"
You should also include "base/string_util.h" here (for base::EmptyString()).

[limasdf, 2014-05-02 16:39:56]

Yep, updated. pushing to CQ then...

[limasdf, 2014-05-02 16:53:08]

The CQ bit was checked by limasdf@gmail.com

[commit-bot: I haz the power, 2014-05-02 16:54:12]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/limasdf@gmail.com/265703011/30001

[commit-bot: I haz the power, 2014-05-02 17:45:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-05-02 17:45:36]

Try jobs failed on following builders:
  mac_chromium_rel on tryserver.chromium

[limasdf, 2014-05-02 17:45:56]

The CQ bit was checked by limasdf@gmail.com

[commit-bot: I haz the power, 2014-05-02 17:46:21]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/limasdf@gmail.com/265703011/30001

[commit-bot: I haz the power, 2014-05-02 18:09:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-05-02 18:09:53]

Try jobs failed on following builders:
  mac_chromium_rel on tryserver.chromium

[limasdf, 2014-05-02 20:20:13]

The CQ bit was checked by limasdf@gmail.com

[commit-bot: I haz the power, 2014-05-02 20:20:47]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/limasdf@gmail.com/265703011/30001

[commit-bot: I haz the power, 2014-05-02 20:36:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-05-02 20:36:11]

Try jobs failed on following builders:
  mac_chromium_rel on tryserver.chromium

[limasdf, 2014-05-03 07:28:13]

The CQ bit was checked by limasdf@gmail.com

[commit-bot: I haz the power, 2014-05-03 07:28:27]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/limasdf@gmail.com/265703011/30001

[commit-bot: I haz the power, 2014-05-03 10:16:50]

Change committed as 268060