chrome/browser/extensions/api/spellcheck/spellcheck_api.cc - Issue 265703011: cleanup: pass string as const reference from c/b/extension/api

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/spellcheck/spellcheck_api.cc

Issue 265703011: cleanup: pass string as const reference from c/b/extension/api (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: add header file for base::EmptyString() Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/extensions/api/spellcheck/spellcheck_api.cc

diff --git a/chrome/browser/extensions/api/spellcheck/spellcheck_api.cc b/chrome/browser/extensions/api/spellcheck/spellcheck_api.cc

index 3f88362d775a817b97e54ddc712b2281f4d112d1..56e4d658614f16da98b049b4e114a2221ad83f7e 100644

--- a/chrome/browser/extensions/api/spellcheck/spellcheck_api.cc

+++ b/chrome/browser/extensions/api/spellcheck/spellcheck_api.cc

@@ -25,7 +25,8 @@ SpellcheckDictionaryInfo* GetSpellcheckDictionaryInfo(

return spellcheck_info;

}

-SpellcheckService::DictionaryFormat GetDictionaryFormat(std::string format) {

+SpellcheckService::DictionaryFormat GetDictionaryFormat(

+ const std::string& format) {

if (format == "hunspell") {

return SpellcheckService::DICT_HUNSPELL;

} else if (format == "text") {

« no previous file with comments | « chrome/browser/extensions/api/image_writer_private/removable_storage_provider_linux.cc ('k') | no next file » | no next file with comments »