chrome/browser/extensions/api/developer_private/developer_private_api.h - Issue 265703011: cleanup: pass string as const reference from c/b/extension/api

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/developer_private/developer_private_api.h

Issue 265703011: cleanup: pass string as const reference from c/b/extension/api (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: add header file for base::EmptyString() Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/extensions/api/developer_private/developer_private_api.h

diff --git a/chrome/browser/extensions/api/developer_private/developer_private_api.h b/chrome/browser/extensions/api/developer_private/developer_private_api.h

index 41ce8e437004bebf79947f62c9e60580bbd37327..66d40608c3f8a1648e8dd7912dac69a05d7afc70 100644

--- a/chrome/browser/extensions/api/developer_private/developer_private_api.h

+++ b/chrome/browser/extensions/api/developer_private/developer_private_api.h

@@ -278,7 +278,7 @@ class DeveloperPrivateEnableFunction

virtual ~DeveloperPrivateEnableFunction();

// Callback for requirements checker.

- void OnRequirementsChecked(std::string extension_id,

+ void OnRequirementsChecked(const std::string& extension_id,

std::vector<std::string> requirements_errors);

// ExtensionFunction:

virtual bool RunSync() OVERRIDE;

« no previous file with comments | « no previous file | chrome/browser/extensions/api/developer_private/developer_private_api.cc » ('j') | no next file with comments »