Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(197)

Side by Side Diff: chrome/browser/extensions/api/developer_private/developer_private_api.h

Issue 265703011: cleanup: pass string as const reference from c/b/extension/api (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: add header file for base::EmptyString() Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | chrome/browser/extensions/api/developer_private/developer_private_api.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_EXTENSIONS_API_DEVELOPER_PRIVATE_DEVELOPER_PRIVATE_API_H_ 5 #ifndef CHROME_BROWSER_EXTENSIONS_API_DEVELOPER_PRIVATE_DEVELOPER_PRIVATE_API_H_
6 #define CHROME_BROWSER_EXTENSIONS_API_DEVELOPER_PRIVATE_DEVELOPER_PRIVATE_API_H_ 6 #define CHROME_BROWSER_EXTENSIONS_API_DEVELOPER_PRIVATE_DEVELOPER_PRIVATE_API_H_
7 7
8 #include <set> 8 #include <set>
9 9
10 #include "base/files/file.h" 10 #include "base/files/file.h"
(...skipping 260 matching lines...) Expand 10 before | Expand all | Expand 10 after
271 public: 271 public:
272 DECLARE_EXTENSION_FUNCTION("developerPrivate.enable", 272 DECLARE_EXTENSION_FUNCTION("developerPrivate.enable",
273 DEVELOPERPRIVATE_ENABLE); 273 DEVELOPERPRIVATE_ENABLE);
274 274
275 DeveloperPrivateEnableFunction(); 275 DeveloperPrivateEnableFunction();
276 276
277 protected: 277 protected:
278 virtual ~DeveloperPrivateEnableFunction(); 278 virtual ~DeveloperPrivateEnableFunction();
279 279
280 // Callback for requirements checker. 280 // Callback for requirements checker.
281 void OnRequirementsChecked(std::string extension_id, 281 void OnRequirementsChecked(const std::string& extension_id,
282 std::vector<std::string> requirements_errors); 282 std::vector<std::string> requirements_errors);
283 // ExtensionFunction: 283 // ExtensionFunction:
284 virtual bool RunSync() OVERRIDE; 284 virtual bool RunSync() OVERRIDE;
285 285
286 private: 286 private:
287 scoped_ptr<RequirementsChecker> requirements_checker_; 287 scoped_ptr<RequirementsChecker> requirements_checker_;
288 }; 288 };
289 289
290 class DeveloperPrivateChooseEntryFunction : public ChromeAsyncExtensionFunction, 290 class DeveloperPrivateChooseEntryFunction : public ChromeAsyncExtensionFunction,
291 public EntryPickerClient { 291 public EntryPickerClient {
(...skipping 169 matching lines...) Expand 10 before | Expand all | Expand 10 after
461 461
462 // ExtensionFunction: 462 // ExtensionFunction:
463 virtual bool RunImpl() OVERRIDE; 463 virtual bool RunImpl() OVERRIDE;
464 }; 464 };
465 465
466 } // namespace api 466 } // namespace api
467 467
468 } // namespace extensions 468 } // namespace extensions
469 469
470 #endif // CHROME_BROWSER_EXTENSIONS_API_DEVELOPER_PRIVATE_DEVELOPER_PRIVATE_API _H_ 470 #endif // CHROME_BROWSER_EXTENSIONS_API_DEVELOPER_PRIVATE_DEVELOPER_PRIVATE_API _H_
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/extensions/api/developer_private/developer_private_api.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698