chrome/browser/extensions/api/developer_private/developer_private_api.cc - Issue 265703011: cleanup: pass string as const reference from c/b/extension/api

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/developer_private/developer_private_api.cc

Issue 265703011: cleanup: pass string as const reference from c/b/extension/api (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: add header file for base::EmptyString() Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/developer_private/developer_private_api.h ('k') | chrome/browser/extensions/api/file_system/file_system_api_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/developer_private/developer_private_api.cc

diff --git a/chrome/browser/extensions/api/developer_private/developer_private_api.cc b/chrome/browser/extensions/api/developer_private/developer_private_api.cc

index 5f9ce42c067715a70843a29d98ccac44d2a6897b..496fe93f3e7178032331b299e110b3efc2705c6f 100644

--- a/chrome/browser/extensions/api/developer_private/developer_private_api.cc

+++ b/chrome/browser/extensions/api/developer_private/developer_private_api.cc

@@ -95,7 +95,7 @@ ExtensionUpdater* GetExtensionUpdater(Profile* profile) {

return profile->GetExtensionService()->updater();

}

-GURL GetImageURLFromData(std::string contents) {

+GURL GetImageURLFromData(const std::string& contents) {

std::string contents_base64;

base::Base64Encode(contents, &contents_base64);

@@ -834,7 +834,7 @@ bool DeveloperPrivateEnableFunction::RunSync() {

}

void DeveloperPrivateEnableFunction::OnRequirementsChecked(

- std::string extension_id,

+ const std::string& extension_id,

std::vector<std::string> requirements_errors) {

if (requirements_errors.empty()) {

ExtensionService* service = GetProfile()->GetExtensionService();