chrome/browser/extensions/api/image_writer_private/removable_storage_provider_linux.cc - Issue 265703011: cleanup: pass string as const reference from c/b/extension/api

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/image_writer_private/removable_storage_provider_linux.cc

Issue 265703011: cleanup: pass string as const reference from c/b/extension/api (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: add header file for base::EmptyString() Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/file_system/file_system_api_unittest.cc ('k') | chrome/browser/extensions/api/spellcheck/spellcheck_api.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/image_writer_private/removable_storage_provider_linux.cc

diff --git a/chrome/browser/extensions/api/image_writer_private/removable_storage_provider_linux.cc b/chrome/browser/extensions/api/image_writer_private/removable_storage_provider_linux.cc

index 9f6385d1cb254ff3882a6a4e7ddb35ce9ab009c9..1c907a53d873599d66bc32056916897858c2d047 100644

--- a/chrome/browser/extensions/api/image_writer_private/removable_storage_provider_linux.cc

+++ b/chrome/browser/extensions/api/image_writer_private/removable_storage_provider_linux.cc

@@ -22,7 +22,7 @@ static uint64 get_int_attr(const char* attr){

return result;

}

-static int get_device_blk_size(std::string path) {

+static int get_device_blk_size(const std::string& path) {

base::FilePath file_path(path);

std::string device = file_path.BaseName().value();