run-webkit-tests: Extract slowness information from MANIFEST.json.

run-webkit-tests: Extract slowness information from MANIFEST.json.

BUG=683807
Review-Url: https://codereview.chromium.org/2656813002
Cr-Commit-Position: refs/heads/master@{#446178}
Committed: https://chromium.googlesource.com/chromium/src/+/c96e02d34a39e6a3e790c563cb506b73aa134e2b

[tkent, 2017-01-25 08:53:14]

The CQ bit was checked by tkent@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-25 08:53:26]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-25 10:16:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-25 10:16:32]

Dry run: This issue passed the CQ dry run.

[tkent, 2017-01-25 14:47:54]

tkent@chromium.org changed reviewers:
+ qyearsley@chromium.org

[tkent, 2017-01-25 14:47:54]

qyearsley@, would you review this please?

[qyearsley, 2017-01-25 19:16:46]

https://codereview.chromium.org/2656813002/diff/1/third_party/WebKit/Tools/Sc...
File third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/base.py
(right):

https://codereview.chromium.org/2656813002/diff/1/third_party/WebKit/Tools/Sc...
third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/base.py:766: match =
re.search(r'external/wpt/(.*)$', test_file)
If test_file is always relative to LayoutTests, then maybe we want re.match
instead of re.search?

  re.search('external/wpt/(.*)$', 'some/subdir/external/wpt/...')  ->  Match
  re.match('external/wpt/(.*)$', 'some/subdir/external/wpt/...')  ->  None

Also, since * is greedy by default, $ is optional:

  re.match('imported/wpt/(.*)', 'imported/wpt/foo/bar.html').group(1)  -> 
'foo/bar.html'

https://codereview.chromium.org/2656813002/diff/1/third_party/WebKit/Tools/Sc...
third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/base.py:770: if
items is None or len(items) == 0:
This could also (optionally) be:
  if not items: ...

https://codereview.chromium.org/2656813002/diff/1/third_party/WebKit/Tools/Sc...
third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/base.py:772: options
= items[0][1]
Depending on the type of test, this will be either items[0][1] or items[0][2],
because in the new manifest format, for reftests the options are third, e.g.:

  ...
  "reftest": {
   "html/dom/elements/global-attributes/dir_auto-EN-L.html": [
    [
     "/html/dom/elements/global-attributes/dir_auto-EN-L.html",
     [
      [
       "/html/dom/elements/global-attributes/dir_auto-EN-L-ref.html",
       "=="
      ]
     ],
     {"timeout": "long"}
    ]
   ],
   ...
  }
  ...

Maybe it might make sense to add little helper functions to get the "url" and
"options" partfrom a manifest item?

[tkent, 2017-01-25 23:23:39]

The CQ bit was checked by tkent@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-25 23:24:24]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tkent, 2017-01-25 23:25:12]

https://codereview.chromium.org/2656813002/diff/1/third_party/WebKit/Tools/Sc...
File third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/base.py
(right):

https://codereview.chromium.org/2656813002/diff/1/third_party/WebKit/Tools/Sc...
third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/base.py:766: match =
re.search(r'external/wpt/(.*)$', test_file)
On 2017/01/25 at 19:16:45, qyearsley wrote:
> If test_file is always relative to LayoutTests, then maybe we want re.match
instead of re.search?
> 
>   re.search('external/wpt/(.*)$', 'some/subdir/external/wpt/...')  ->  Match
>   re.match('external/wpt/(.*)$', 'some/subdir/external/wpt/...')  ->  None
> 
> Also, since * is greedy by default, $ is optional:
> 
>   re.match('imported/wpt/(.*)', 'imported/wpt/foo/bar.html').group(1)  -> 
'foo/bar.html'

Done.

https://codereview.chromium.org/2656813002/diff/1/third_party/WebKit/Tools/Sc...
third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/base.py:770: if
items is None or len(items) == 0:
On 2017/01/25 at 19:16:45, qyearsley wrote:
> This could also (optionally) be:
>   if not items: ...

Done.

https://codereview.chromium.org/2656813002/diff/1/third_party/WebKit/Tools/Sc...
third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/base.py:772: options
= items[0][1]
On 2017/01/25 at 19:16:45, qyearsley wrote:
> Depending on the type of test, this will be either items[0][1] or items[0][2],
because in the new manifest format, for reftests the options are third, e.g.:
> 
>   ...
>   "reftest": {
>    "html/dom/elements/global-attributes/dir_auto-EN-L.html": [
>     [
>      "/html/dom/elements/global-attributes/dir_auto-EN-L.html",
>      [
>       [
>        "/html/dom/elements/global-attributes/dir_auto-EN-L-ref.html",
>        "=="
>       ]
>      ],
>      {"timeout": "long"}
>     ]
>    ],
>    ...
>   }
>   ...
> 
> Maybe it might make sense to add little helper functions to get the "url" and
"options" partfrom a manifest item?

Done.
BTW, I found the field was called "extras" in manifest tool.

[qyearsley, 2017-01-25 23:30:49]

lgtm, thanks for making this change

[commit-bot: I haz the power, 2017-01-26 00:28:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-26 00:28:18]

Dry run: This issue passed the CQ dry run.

[tkent, 2017-01-26 00:28:49]

The CQ bit was checked by tkent@chromium.org

[commit-bot: I haz the power, 2017-01-26 00:29:41]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-26 00:53:41]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1485390529169600,
"parent_rev": "e3737854d8bf3f7d81ae7e5d852b0c914541935f", "commit_rev":
"c96e02d34a39e6a3e790c563cb506b73aa134e2b"}

[commit-bot: I haz the power, 2017-01-26 00:54:10]

Description was changed from

==========
run-webkit-tests: Extract slowness information from MANIFEST.json.

BUG=683807
==========

to

==========
run-webkit-tests: Extract slowness information from MANIFEST.json.

BUG=683807

Review-Url: https://codereview.chromium.org/2656813002
Cr-Commit-Position: refs/heads/master@{#446178}
Committed:
https://chromium.googlesource.com/chromium/src/+/c96e02d34a39e6a3e790c563cb50...
==========

[commit-bot: I haz the power, 2017-01-26 00:54:11]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/c96e02d34a39e6a3e790c563cb50...