third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py - Issue 2656813002: run-webkit-tests: Extract slowness information from MANIFEST.json.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py

Issue 2656813002: run-webkit-tests: Extract slowness information from MANIFEST.json. (Closed)

Patch Set: Improve regex matching, add _get_extras_from_manifest_item() Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/SlowTests ('k') | third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/base.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py

diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py b/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py

index 3ef668d381f7b009dd8addb5796cacd504744467..716476b9fdeefda56ba69076bc3dce9e36c3ae37 100644

--- a/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py

+++ b/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py

@@ -282,7 +282,7 @@ class Manager(object):

test_expectations.NEEDS_MANUAL_REBASELINE in expectations)

def _test_is_slow(self, test_file):

- return test_expectations.SLOW in self._expectations.model().get_expectations(test_file)

+ return test_expectations.SLOW in self._expectations.model().get_expectations(test_file) or self._port.is_slow_wpt_test(test_file)

def _needs_servers(self, test_names):

return any(self._test_requires_lock(test_name) for test_name in test_names)

« no previous file with comments | « third_party/WebKit/LayoutTests/SlowTests ('k') | third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/base.py » ('j') | no next file with comments »