Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(190)

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/base_unittest.py

Issue 2656813002: run-webkit-tests: Extract slowness information from MANIFEST.json. (Closed)
Patch Set: Improve regex matching, add _get_extras_from_manifest_item() Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/base.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/base_unittest.py
diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/base_unittest.py b/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/base_unittest.py
index d7b4232e301ab81d756d55a4f16c04b565ff3de7..f9953679301cce7cc30078d4602a3f9b895dd2f8 100644
--- a/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/base_unittest.py
+++ b/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/base_unittest.py
@@ -251,13 +251,29 @@ class PortTest(unittest.TestCase):
'dom/ranges/Range-attributes.html': [
['/dom/ranges/Range-attributes.html', {}]
],
+ 'dom/ranges/Range-attributes-slow.html': [
+ ['/dom/ranges/Range-attributes.html', {'timeout': 'long'}]
+ ],
'console/console-is-a-namespace.any.js': [
['/console/console-is-a-namespace.any.html', {}],
['/console/console-is-a-namespace.any.worker.html', {}],
],
},
'manual': {},
- 'reftest': {},
+ 'reftest': {
+ 'html/dom/elements/global-attributes/dir_auto-EN-L.html': [
+ [
+ '/html/dom/elements/global-attributes/dir_auto-EN-L.html',
+ [
+ [
+ '/html/dom/elements/global-attributes/dir_auto-EN-L-ref.html',
+ '=='
+ ]
+ ],
+ {'timeout': 'long'}
+ ]
+ ],
+ },
}}))
filesystem.write_text_file(LAYOUT_TEST_DIR + '/external/wpt/dom/ranges/Range-attributes.html', '')
filesystem.write_text_file(LAYOUT_TEST_DIR + '/external/wpt/console/console-is-a-namespace.any.js', '')
@@ -321,6 +337,16 @@ class PortTest(unittest.TestCase):
# A file in external/wpt_automation.
self.assertTrue(port.is_test_file(filesystem, LAYOUT_TEST_DIR + '/external/wpt_automation', 'foo.html'))
+ def test_is_slow_wpt_test(self):
+ port = self.make_port(with_tests=True)
+ filesystem = port.host.filesystem
+ PortTest._add_manifest_to_mock_file_system(filesystem)
+
+ self.assertFalse(port.is_slow_wpt_test('external/wpt/dom/ranges/Range-attributes.html'))
+ self.assertFalse(port.is_slow_wpt_test('dom/ranges/Range-attributes.html'))
+ self.assertTrue(port.is_slow_wpt_test('external/wpt/dom/ranges/Range-attributes-slow.html'))
+ self.assertTrue(port.is_slow_wpt_test('external/wpt/html/dom/elements/global-attributes/dir_auto-EN-L.html'))
+
def test_parse_reftest_list(self):
port = self.make_port(with_tests=True)
port.host.filesystem.files['bar/reftest.list'] = "\n".join(["== test.html test-ref.html",
« no previous file with comments | « third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/base.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698