Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(226)

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/base.py

Issue 2656813002: run-webkit-tests: Extract slowness information from MANIFEST.json. (Closed)
Patch Set: Improve regex matching, add _get_extras_from_manifest_item() Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/base.py
diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/base.py b/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/base.py
index 80a92d76767a3454cb98a7b5b2b834f9fcc07687..b739d1dc809046dc84a7a795d540023b9e047d67 100644
--- a/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/base.py
+++ b/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/base.py
@@ -762,6 +762,20 @@ class Port(object):
return items['testharness'][path_in_wpt]
return None
+ @staticmethod
+ def _get_extras_from_manifest_item(item):
+ return item[-1]
+
+ def is_slow_wpt_test(self, test_file):
+ match = re.match(r'external/wpt/(.*)', test_file)
+ if not match:
+ return False
+ items = self._manifest_items_for_path(match.group(1))
+ if not items:
+ return False
+ extras = Port._get_extras_from_manifest_item(items[0])
+ return 'timeout' in extras and extras['timeout'] == 'long'
+
ALL_TEST_TYPES = ['audio', 'harness', 'pixel', 'ref', 'text', 'unknown']
def test_type(self, test_name):

Powered by Google App Engine
This is Rietveld 408576698