run-webkit-tests: Extract slowness information from MANIFEST.json.

third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/base.py

 # Copyright (C) 2010 Google Inc. All rights reserved.
 #
 # Redistribution and use in source and binary forms, with or without
 # modification, are permitted provided that the following conditions are
 # met:
 #
 #     * Redistributions of source code must retain the above copyright
 # notice, this list of conditions and the following disclaimer.
 #     * Redistributions in binary form must reproduce the above
 # copyright notice, this list of conditions and the following disclaimer
@@ skipping 744 matching lines @@
         """
         items = self._wpt_manifest()['items']
         if path_in_wpt in items['manual']:
             return items['manual'][path_in_wpt]
         elif path_in_wpt in items['reftest']:
             return items['reftest'][path_in_wpt]
         elif path_in_wpt in items['testharness']:
             return items['testharness'][path_in_wpt]
         return None
 
+    def is_slow_wpt_test(self, test_file):
+        match = re.search(r'external/wpt/(.*)$', test_file)

[qyearsley, 2017/01/25 19:16:45]

If test_file is always relative to LayoutTests, then maybe we want re.match
instead of re.search?

  re.search('external/wpt/(.*)$', 'some/subdir/external/wpt/...')  ->  Match
  re.match('external/wpt/(.*)$', 'some/subdir/external/wpt/...')  ->  None

Also, since * is greedy by default, $ is optional:

  re.match('imported/wpt/(.*)', 'imported/wpt/foo/bar.html').group(1)  -> 
'foo/bar.html'

[tkent, 2017/01/25 23:25:12]

Done.

+        if not match:
+            return False
+        items = self._manifest_items_for_path(match.group(1))
+        if items is None or len(items) == 0:

[qyearsley, 2017/01/25 19:16:45]

This could also (optionally) be:
  if not items: ...

[tkent, 2017/01/25 23:25:12]

Done.

+            return False
+        options = items[0][1]

[qyearsley, 2017/01/25 19:16:45]

Depending on the type of test, this will be either items[0][1] or items[0][2],
because in the new manifest format, for reftests the options are third, e.g.:

  ...
  "reftest": {
   "html/dom/elements/global-attributes/dir_auto-EN-L.html": [
    [
     "/html/dom/elements/global-attributes/dir_auto-EN-L.html",
     [
      [
       "/html/dom/elements/global-attributes/dir_auto-EN-L-ref.html",
       "=="
      ]
     ],
     {"timeout": "long"}
    ]
   ],
   ...
  }
  ...

Maybe it might make sense to add little helper functions to get the "url" and
"options" partfrom a manifest item?

[tkent, 2017/01/25 23:25:12]

Done.
BTW, I found the field was called "extras" in manifest tool.

+        return 'timeout' in options and options['timeout'] == 'long'
+
     ALL_TEST_TYPES = ['audio', 'harness', 'pixel', 'ref', 'text', 'unknown']
 
     def test_type(self, test_name):
         fs = self._filesystem
         if fs.exists(self.expected_filename(test_name, '.png')):
             return 'pixel'
         if fs.exists(self.expected_filename(test_name, '.wav')):
             return 'audio'
         if self.reference_files(test_name):
             return 'ref'
@@ skipping 870 matching lines @@
 
     def __init__(self, base, args, reference_args=None):
         self.name = base
         self.base = base
         self.args = args
         self.reference_args = args if reference_args is None else reference_args
         self.tests = set()
 
     def __repr__(self):
         return "PhysicalTestSuite('%s', '%s', %s, %s)" % (self.name, self.base, self.args, self.reference_args)