Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(173)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2654183002: Rename references to "external pages" as "snapshot pages" to avoid confusion with the kind of exter… (Closed)

Created:
3 years, 11 months ago by rmacnak
Modified:
3 years, 11 months ago
Reviewers:
siva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Rename references to "external pages" as "image pages" to avoid confusion with the kind of external memory associated with finalizers. R=asiva@google.com Committed: https://github.com/dart-lang/sdk/commit/8b217ec519ec03556116f509a6122f3c3cfcdf98

Patch Set 1 #

Patch Set 2 : image #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+157 lines, -214 lines) Patch
M runtime/vm/benchmark_test.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/vm/clustered_snapshot.h View 1 5 chunks +8 lines, -8 lines 0 comments Download
M runtime/vm/clustered_snapshot.cc View 1 9 chunks +28 lines, -25 lines 0 comments Download
M runtime/vm/dart_api_impl.cc View 1 4 chunks +21 lines, -23 lines 0 comments Download
M runtime/vm/gc_sweeper.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/heap.h View 1 3 chunks +5 lines, -5 lines 0 comments Download
M runtime/vm/heap.cc View 1 3 chunks +8 lines, -8 lines 0 comments Download
M runtime/vm/isolate.h View 1 1 chunk +1 line, -3 lines 0 comments Download
M runtime/vm/isolate.cc View 1 1 chunk +4 lines, -29 lines 3 comments Download
M runtime/vm/object.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M runtime/vm/object.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M runtime/vm/object_graph.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/vm/pages.h View 1 3 chunks +4 lines, -4 lines 0 comments Download
M runtime/vm/pages.cc View 1 10 chunks +17 lines, -22 lines 0 comments Download
M runtime/vm/raw_object.h View 1 2 chunks +4 lines, -4 lines 0 comments Download
M runtime/vm/snapshot.h View 1 6 chunks +23 lines, -51 lines 0 comments Download
M runtime/vm/snapshot.cc View 1 7 chunks +9 lines, -10 lines 0 comments Download
M runtime/vm/snapshot_test.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/vm/virtual_memory.h View 1 3 chunks +7 lines, -5 lines 0 comments Download
M runtime/vm/virtual_memory.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M runtime/vm/virtual_memory_android.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/virtual_memory_fuchsia.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/virtual_memory_linux.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/virtual_memory_macos.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/virtual_memory_win.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
rmacnak
3 years, 11 months ago (2017-01-25 21:20:24 UTC) #2
rmacnak
Changed to "image"
3 years, 11 months ago (2017-01-25 23:18:16 UTC) #4
siva
lgtm https://codereview.chromium.org/2654183002/diff/20001/runtime/vm/isolate.cc File runtime/vm/isolate.cc (left): https://codereview.chromium.org/2654183002/diff/20001/runtime/vm/isolate.cc#oldcode1012 runtime/vm/isolate.cc:1012: #endif Why did you delete these trace messages? ...
3 years, 11 months ago (2017-01-26 01:07:30 UTC) #5
rmacnak
https://codereview.chromium.org/2654183002/diff/20001/runtime/vm/isolate.cc File runtime/vm/isolate.cc (left): https://codereview.chromium.org/2654183002/diff/20001/runtime/vm/isolate.cc#oldcode1012 runtime/vm/isolate.cc:1012: #endif On 2017/01/26 01:07:30, siva wrote: > Why did ...
3 years, 11 months ago (2017-01-26 17:39:00 UTC) #6
rmacnak
3 years, 11 months ago (2017-01-26 17:53:13 UTC) #8
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
8b217ec519ec03556116f509a6122f3c3cfcdf98 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698