runtime/vm/virtual_memory_fuchsia.cc - Issue 2654183002: Rename references to "external pages" as "snapshot pages" to avoid confusion with the kind of exter…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/virtual_memory_fuchsia.cc

Issue 2654183002: Rename references to "external pages" as "snapshot pages" to avoid confusion with the kind of exter… (Closed)

Patch Set: image Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/vm/virtual_memory_fuchsia.cc

diff --git a/runtime/vm/virtual_memory_fuchsia.cc b/runtime/vm/virtual_memory_fuchsia.cc

index 058bbac4e4c4533496ce786f5cd36d7cae8d1b19..08919db6e1bb45c543054893a1add890192a447a 100644

--- a/runtime/vm/virtual_memory_fuchsia.cc

+++ b/runtime/vm/virtual_memory_fuchsia.cc

@@ -171,7 +171,7 @@ VirtualMemory* VirtualMemory::ReserveInternal(intptr_t size) {

VirtualMemory::~VirtualMemory() {

- if (!embedder_allocated()) {

+ if (vm_owns_region()) {

mx_handle_t vmar = static_cast<mx_handle_t>(handle());

mx_status_t status = mx_vmar_destroy(vmar);

if (status != NO_ERROR) {