Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(236)

Side by Side Diff: runtime/vm/virtual_memory_linux.cc

Issue 2654183002: Rename references to "external pages" as "snapshot pages" to avoid confusion with the kind of exter… (Closed)
Patch Set: image Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/globals.h" 5 #include "vm/globals.h"
6 #if defined(TARGET_OS_LINUX) 6 #if defined(TARGET_OS_LINUX)
7 7
8 #include "vm/virtual_memory.h" 8 #include "vm/virtual_memory.h"
9 9
10 #include <sys/mman.h> // NOLINT 10 #include <sys/mman.h> // NOLINT
(...skipping 35 matching lines...) Expand 10 before | Expand all | Expand 10 after
46 return; 46 return;
47 } 47 }
48 48
49 if (munmap(address, size) != 0) { 49 if (munmap(address, size) != 0) {
50 FATAL("munmap failed\n"); 50 FATAL("munmap failed\n");
51 } 51 }
52 } 52 }
53 53
54 54
55 VirtualMemory::~VirtualMemory() { 55 VirtualMemory::~VirtualMemory() {
56 if (!embedder_allocated()) { 56 if (vm_owns_region()) {
57 unmap(address(), reserved_size_); 57 unmap(address(), reserved_size_);
58 } 58 }
59 } 59 }
60 60
61 61
62 bool VirtualMemory::FreeSubSegment(int32_t handle, 62 bool VirtualMemory::FreeSubSegment(int32_t handle,
63 void* address, 63 void* address,
64 intptr_t size) { 64 intptr_t size) {
65 unmap(address, size); 65 unmap(address, size);
66 return true; 66 return true;
(...skipping 38 matching lines...) Expand 10 before | Expand all | Expand 10 after
105 break; 105 break;
106 } 106 }
107 return (mprotect(reinterpret_cast<void*>(page_address), 107 return (mprotect(reinterpret_cast<void*>(page_address),
108 end_address - page_address, prot) == 0); 108 end_address - page_address, prot) == 0);
109 } 109 }
110 110
111 111
112 } // namespace dart 112 } // namespace dart
113 113
114 #endif // defined(TARGET_OS_LINUX) 114 #endif // defined(TARGET_OS_LINUX)
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698