runtime/vm/virtual_memory_win.cc - Issue 2654183002: Rename references to "external pages" as "snapshot pages" to avoid confusion with the kind of exter…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/virtual_memory_win.cc

Issue 2654183002: Rename references to "external pages" as "snapshot pages" to avoid confusion with the kind of exter… (Closed)

Patch Set: image Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/vm/virtual_memory_win.cc

diff --git a/runtime/vm/virtual_memory_win.cc b/runtime/vm/virtual_memory_win.cc

index 7e876a4281cf8f6fc077a394ac7958116a223e78..0f4b1797d60257f5de79faa69f21e9dc5f92c072 100644

--- a/runtime/vm/virtual_memory_win.cc

+++ b/runtime/vm/virtual_memory_win.cc

@@ -35,7 +35,7 @@ VirtualMemory* VirtualMemory::ReserveInternal(intptr_t size) {

VirtualMemory::~VirtualMemory() {

- if (embedder_allocated() || (reserved_size_ == 0)) {

+ if (!vm_owns_region() || (reserved_size_ == 0)) {

return;

}

if (VirtualFree(address(), 0, MEM_RELEASE) == 0) {

« runtime/vm/isolate.cc ('K') | « runtime/vm/virtual_memory_macos.cc ('k') | no next file » | no next file with comments »