Revert of Sync requestFullscreen() and exitFullscreen() algorithms with the spec

Revert of Sync requestFullscreen() and exitFullscreen() algorithms with the spec (patchset #3 id:40001 of https://codereview.chromium.org/2573773002/ )

Reason for revert:
Delaying fullscreen element stack changes until the animation frame
after resize, and thus after resize-triggered scroll events, caused a
regression with twitter video embeds that may require spec changes to
fix: https://github.com/whatwg/fullscreen/issues/74

BUG=680467
Original issue's description:
> Sync requestFullscreen() and exitFullscreen() algorithms with the spec
> 
> The central change is the timing for when the fullscreen element stack
> is modified and when the events fire. This makes it possible to make
> webkitCurrentFullScreenElement an alias of fullscreenElement, as the old
> notion of a single fullscreen element is gone.
> 
> Previously, fullscreen requests did:
>  1. In Fullscreen::requestFullscreen(), synchronously modify
>     m_fullscreenElementStack, visible in document.fullscreenElement, but
>     not document.webkitCurrentFullScreenElement. Also enqueue events to
>     fire, without starting the timer to fire them.
>  2. As soon as the resize happens, in Fullscreen::didEnterFullscreen(),
>     set m_currentFullScreenElement, affecting :-webkit-full-screen
>     document.webkitCurrentFullScreenElement. Start the event timer.
>  3. When the timer fires, events are dispatched. If the tree has changed
>     since the events were enqueued, additional events may be fired.
> 
> And similarly for exit. For errors, requestFullscreen() would itself
> start the timer to fire the events.
> 
> Now, fullscreen requests will:
>  1. In Fullscreen::requestFullscreen(), append to a list of pending
>     requests.
>  2. When the resize happens, enqueue an animation frame task for each
>     pending request.
>  3. In the animation frame task, apply all changes, decide which events
>     to fire and then fire them.
> 
> TEST=run-webkit-tests fullscreen/ imported/wpt/fullscreen/
>      webkit_unit_tests --gtest_filter=*Fullscreen*
>      interactive_ui_tests --gtest_filter=SitePerProcessInteractiveBrowserTest.Fullscreen*
> BUG=402376, 402421
> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
> 
> Committed: https://crrev.com/e1d42d636990425056ede44086ef49a1f8c6a0a5
> Cr-Commit-Position: refs/heads/master@{#439607}

TBR=mlamouri@chromium.org,alexmos@chromium.org,eae@chromium.org,esprehn@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=402376, 402421
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2654083006
Cr-Commit-Position: refs/heads/master@{#446643}
Committed: https://chromium.googlesource.com/chromium/src/+/675e4f2fe55c349ac3ba67405c15c36ec7419cb6

[foolip, 2017-01-26 18:44:12]

Created Revert of Sync requestFullscreen() and exitFullscreen() algorithms with
the spec

[foolip, 2017-01-26 18:45:06]

Description was changed from

==========
Revert of Sync requestFullscreen() and exitFullscreen() algorithms with the spec
(patchset #3 id:40001 of https://codereview.chromium.org/2573773002/ )

Reason for revert:
Delaying fullscreen element stack changes until the animation frame after
resize, and thus after resize-triggered scroll events, caused a regression with
twitter video embeds that may require spec changes to fix:
https://github.com/whatwg/fullscreen/issues/74

BUG=680467

Original issue's description:
> Sync requestFullscreen() and exitFullscreen() algorithms with the spec
> 
> The central change is the timing for when the fullscreen element stack
> is modified and when the events fire. This makes it possible to make
> webkitCurrentFullScreenElement an alias of fullscreenElement, as the old
> notion of a single fullscreen element is gone.
> 
> Previously, fullscreen requests did:
>  1. In Fullscreen::requestFullscreen(), synchronously modify
>     m_fullscreenElementStack, visible in document.fullscreenElement, but
>     not document.webkitCurrentFullScreenElement. Also enqueue events to
>     fire, without starting the timer to fire them.
>  2. As soon as the resize happens, in Fullscreen::didEnterFullscreen(),
>     set m_currentFullScreenElement, affecting :-webkit-full-screen
>     document.webkitCurrentFullScreenElement. Start the event timer.
>  3. When the timer fires, events are dispatched. If the tree has changed
>     since the events were enqueued, additional events may be fired.
> 
> And similarly for exit. For errors, requestFullscreen() would itself
> start the timer to fire the events.
> 
> Now, fullscreen requests will:
>  1. In Fullscreen::requestFullscreen(), append to a list of pending
>     requests.
>  2. When the resize happens, enqueue an animation frame task for each
>     pending request.
>  3. In the animation frame task, apply all changes, decide which events
>     to fire and then fire them.
> 
> TEST=run-webkit-tests fullscreen/ imported/wpt/fullscreen/
>      webkit_unit_tests --gtest_filter=*Fullscreen*
>      interactive_ui_tests
--gtest_filter=SitePerProcessInteractiveBrowserTest.Fullscreen*
> BUG=402376,402421
>
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
> 
> Committed: https://crrev.com/e1d42d636990425056ede44086ef49a1f8c6a0a5
> Cr-Commit-Position: refs/heads/master@{#439607}

TBR=mlamouri@chromium.org,alexmos@chromium.org,eae@chromium.org,esprehn@chrom...
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=402376,402421
==========

to

==========
Revert of Sync requestFullscreen() and exitFullscreen() algorithms with the spec
(patchset #3 id:40001 of https://codereview.chromium.org/2573773002/ )

Reason for revert:
Delaying fullscreen element stack changes until the animation frame
after resize, and thus after resize-triggered scroll events, caused a
regression with twitter video embeds that may require spec changes to
fix: https://github.com/whatwg/fullscreen/issues/74

BUG=680467

Original issue's description:
> Sync requestFullscreen() and exitFullscreen() algorithms with the spec
> 
> The central change is the timing for when the fullscreen element stack
> is modified and when the events fire. This makes it possible to make
> webkitCurrentFullScreenElement an alias of fullscreenElement, as the old
> notion of a single fullscreen element is gone.
> 
> Previously, fullscreen requests did:
>  1. In Fullscreen::requestFullscreen(), synchronously modify
>     m_fullscreenElementStack, visible in document.fullscreenElement, but
>     not document.webkitCurrentFullScreenElement. Also enqueue events to
>     fire, without starting the timer to fire them.
>  2. As soon as the resize happens, in Fullscreen::didEnterFullscreen(),
>     set m_currentFullScreenElement, affecting :-webkit-full-screen
>     document.webkitCurrentFullScreenElement. Start the event timer.
>  3. When the timer fires, events are dispatched. If the tree has changed
>     since the events were enqueued, additional events may be fired.
> 
> And similarly for exit. For errors, requestFullscreen() would itself
> start the timer to fire the events.
> 
> Now, fullscreen requests will:
>  1. In Fullscreen::requestFullscreen(), append to a list of pending
>     requests.
>  2. When the resize happens, enqueue an animation frame task for each
>     pending request.
>  3. In the animation frame task, apply all changes, decide which events
>     to fire and then fire them.
> 
> TEST=run-webkit-tests fullscreen/ imported/wpt/fullscreen/
>      webkit_unit_tests --gtest_filter=*Fullscreen*
>      interactive_ui_tests
--gtest_filter=SitePerProcessInteractiveBrowserTest.Fullscreen*
> BUG=402376,402421
>
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
> 
> Committed: https://crrev.com/e1d42d636990425056ede44086ef49a1f8c6a0a5
> Cr-Commit-Position: refs/heads/master@{#439607}

TBR=mlamouri@chromium.org,alexmos@chromium.org,eae@chromium.org,esprehn@chrom...
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=402376,402421
==========

[eae, 2017-01-26 18:45:12]

LGTM

[foolip, 2017-01-26 19:28:29]

Description was changed from

==========
Revert of Sync requestFullscreen() and exitFullscreen() algorithms with the spec
(patchset #3 id:40001 of https://codereview.chromium.org/2573773002/ )

Reason for revert:
Delaying fullscreen element stack changes until the animation frame
after resize, and thus after resize-triggered scroll events, caused a
regression with twitter video embeds that may require spec changes to
fix: https://github.com/whatwg/fullscreen/issues/74

BUG=680467

Original issue's description:
> Sync requestFullscreen() and exitFullscreen() algorithms with the spec
> 
> The central change is the timing for when the fullscreen element stack
> is modified and when the events fire. This makes it possible to make
> webkitCurrentFullScreenElement an alias of fullscreenElement, as the old
> notion of a single fullscreen element is gone.
> 
> Previously, fullscreen requests did:
>  1. In Fullscreen::requestFullscreen(), synchronously modify
>     m_fullscreenElementStack, visible in document.fullscreenElement, but
>     not document.webkitCurrentFullScreenElement. Also enqueue events to
>     fire, without starting the timer to fire them.
>  2. As soon as the resize happens, in Fullscreen::didEnterFullscreen(),
>     set m_currentFullScreenElement, affecting :-webkit-full-screen
>     document.webkitCurrentFullScreenElement. Start the event timer.
>  3. When the timer fires, events are dispatched. If the tree has changed
>     since the events were enqueued, additional events may be fired.
> 
> And similarly for exit. For errors, requestFullscreen() would itself
> start the timer to fire the events.
> 
> Now, fullscreen requests will:
>  1. In Fullscreen::requestFullscreen(), append to a list of pending
>     requests.
>  2. When the resize happens, enqueue an animation frame task for each
>     pending request.
>  3. In the animation frame task, apply all changes, decide which events
>     to fire and then fire them.
> 
> TEST=run-webkit-tests fullscreen/ imported/wpt/fullscreen/
>      webkit_unit_tests --gtest_filter=*Fullscreen*
>      interactive_ui_tests
--gtest_filter=SitePerProcessInteractiveBrowserTest.Fullscreen*
> BUG=402376,402421
>
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
> 
> Committed: https://crrev.com/e1d42d636990425056ede44086ef49a1f8c6a0a5
> Cr-Commit-Position: refs/heads/master@{#439607}

TBR=mlamouri@chromium.org,alexmos@chromium.org,eae@chromium.org,esprehn@chrom...
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=402376,402421
==========

to

==========
Revert of Sync requestFullscreen() and exitFullscreen() algorithms with the spec
(patchset #3 id:40001 of https://codereview.chromium.org/2573773002/ )

Reason for revert:
Delaying fullscreen element stack changes until the animation frame
after resize, and thus after resize-triggered scroll events, caused a
regression with twitter video embeds that may require spec changes to
fix: https://github.com/whatwg/fullscreen/issues/74

BUG=680467

Original issue's description:
> Sync requestFullscreen() and exitFullscreen() algorithms with the spec
> 
> The central change is the timing for when the fullscreen element stack
> is modified and when the events fire. This makes it possible to make
> webkitCurrentFullScreenElement an alias of fullscreenElement, as the old
> notion of a single fullscreen element is gone.
> 
> Previously, fullscreen requests did:
>  1. In Fullscreen::requestFullscreen(), synchronously modify
>     m_fullscreenElementStack, visible in document.fullscreenElement, but
>     not document.webkitCurrentFullScreenElement. Also enqueue events to
>     fire, without starting the timer to fire them.
>  2. As soon as the resize happens, in Fullscreen::didEnterFullscreen(),
>     set m_currentFullScreenElement, affecting :-webkit-full-screen
>     document.webkitCurrentFullScreenElement. Start the event timer.
>  3. When the timer fires, events are dispatched. If the tree has changed
>     since the events were enqueued, additional events may be fired.
> 
> And similarly for exit. For errors, requestFullscreen() would itself
> start the timer to fire the events.
> 
> Now, fullscreen requests will:
>  1. In Fullscreen::requestFullscreen(), append to a list of pending
>     requests.
>  2. When the resize happens, enqueue an animation frame task for each
>     pending request.
>  3. In the animation frame task, apply all changes, decide which events
>     to fire and then fire them.
> 
> TEST=run-webkit-tests fullscreen/ imported/wpt/fullscreen/
>      webkit_unit_tests --gtest_filter=*Fullscreen*
>      interactive_ui_tests
--gtest_filter=SitePerProcessInteractiveBrowserTest.Fullscreen*
> BUG=402376,402421
>
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
> 
> Committed: https://crrev.com/e1d42d636990425056ede44086ef49a1f8c6a0a5
> Cr-Commit-Position: refs/heads/master@{#439607}

TBR=mlamouri@chromium.org,alexmos@chromium.org,eae@chromium.org,esprehn@chrom...
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=402376,402421
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[foolip, 2017-01-26 19:28:42]

The CQ bit was checked by foolip@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-26 19:29:25]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[foolip, 2017-01-26 19:31:57]

The CQ bit was checked by foolip@chromium.org to run a CQ dry run

[foolip, 2017-01-26 19:33:13]

foolip@chromium.org changed reviewers:
+ wangxianzhu@chromium.org

[foolip, 2017-01-26 19:33:13]

wangxianzhu@, this is just a revert, but I had to change your code from
https://codereview.chromium.org/2599573002 a bit, would you care to review those
bits?

[commit-bot: I haz the power, 2017-01-26 19:33:38]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Xianzhu, 2017-01-26 19:48:56]

On 2017/01/26 19:33:13, foolip_UTC7 wrote:
> wangxianzhu@, this is just a revert, but I had to change your code from
> https://codereview.chromium.org/2599573002 a bit, would you care to review
those
> bits?

The bits LGTM.

[commit-bot: I haz the power, 2017-01-26 21:13:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-26 21:14:00]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[foolip, 2017-01-27 06:27:32]

The CQ bit was checked by foolip@chromium.org

[foolip, 2017-01-27 06:27:33]

The patchset sent to the CQ was uploaded after l-g-t-m from eae@chromium.org,
wangxianzhu@chromium.org
Link to the patchset: https://codereview.chromium.org/2654083006/#ps340001
(title: "add failing test expectations")

[commit-bot: I haz the power, 2017-01-27 06:27:51]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-27 09:36:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-27 09:36:56]

Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[foolip, 2017-01-27 09:46:36]

The CQ bit was checked by foolip@chromium.org

[commit-bot: I haz the power, 2017-01-27 09:46:55]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-27 11:05:40]

CQ is committing da patch.

Bot data: {"patchset_id": 340001, "attempt_start_ts": 1485510396440320,
"parent_rev": "c0a2365a06eb4f8fae329b9dc973dc7e29ec3bc1", "commit_rev":
"675e4f2fe55c349ac3ba67405c15c36ec7419cb6"}

[commit-bot: I haz the power, 2017-01-27 11:06:11]

Description was changed from

==========
Revert of Sync requestFullscreen() and exitFullscreen() algorithms with the spec
(patchset #3 id:40001 of https://codereview.chromium.org/2573773002/ )

Reason for revert:
Delaying fullscreen element stack changes until the animation frame
after resize, and thus after resize-triggered scroll events, caused a
regression with twitter video embeds that may require spec changes to
fix: https://github.com/whatwg/fullscreen/issues/74

BUG=680467

Original issue's description:
> Sync requestFullscreen() and exitFullscreen() algorithms with the spec
> 
> The central change is the timing for when the fullscreen element stack
> is modified and when the events fire. This makes it possible to make
> webkitCurrentFullScreenElement an alias of fullscreenElement, as the old
> notion of a single fullscreen element is gone.
> 
> Previously, fullscreen requests did:
>  1. In Fullscreen::requestFullscreen(), synchronously modify
>     m_fullscreenElementStack, visible in document.fullscreenElement, but
>     not document.webkitCurrentFullScreenElement. Also enqueue events to
>     fire, without starting the timer to fire them.
>  2. As soon as the resize happens, in Fullscreen::didEnterFullscreen(),
>     set m_currentFullScreenElement, affecting :-webkit-full-screen
>     document.webkitCurrentFullScreenElement. Start the event timer.
>  3. When the timer fires, events are dispatched. If the tree has changed
>     since the events were enqueued, additional events may be fired.
> 
> And similarly for exit. For errors, requestFullscreen() would itself
> start the timer to fire the events.
> 
> Now, fullscreen requests will:
>  1. In Fullscreen::requestFullscreen(), append to a list of pending
>     requests.
>  2. When the resize happens, enqueue an animation frame task for each
>     pending request.
>  3. In the animation frame task, apply all changes, decide which events
>     to fire and then fire them.
> 
> TEST=run-webkit-tests fullscreen/ imported/wpt/fullscreen/
>      webkit_unit_tests --gtest_filter=*Fullscreen*
>      interactive_ui_tests
--gtest_filter=SitePerProcessInteractiveBrowserTest.Fullscreen*
> BUG=402376,402421
>
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
> 
> Committed: https://crrev.com/e1d42d636990425056ede44086ef49a1f8c6a0a5
> Cr-Commit-Position: refs/heads/master@{#439607}

TBR=mlamouri@chromium.org,alexmos@chromium.org,eae@chromium.org,esprehn@chrom...
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=402376,402421
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Revert of Sync requestFullscreen() and exitFullscreen() algorithms with the spec
(patchset #3 id:40001 of https://codereview.chromium.org/2573773002/ )

Reason for revert:
Delaying fullscreen element stack changes until the animation frame
after resize, and thus after resize-triggered scroll events, caused a
regression with twitter video embeds that may require spec changes to
fix: https://github.com/whatwg/fullscreen/issues/74

BUG=680467

Original issue's description:
> Sync requestFullscreen() and exitFullscreen() algorithms with the spec
> 
> The central change is the timing for when the fullscreen element stack
> is modified and when the events fire. This makes it possible to make
> webkitCurrentFullScreenElement an alias of fullscreenElement, as the old
> notion of a single fullscreen element is gone.
> 
> Previously, fullscreen requests did:
>  1. In Fullscreen::requestFullscreen(), synchronously modify
>     m_fullscreenElementStack, visible in document.fullscreenElement, but
>     not document.webkitCurrentFullScreenElement. Also enqueue events to
>     fire, without starting the timer to fire them.
>  2. As soon as the resize happens, in Fullscreen::didEnterFullscreen(),
>     set m_currentFullScreenElement, affecting :-webkit-full-screen
>     document.webkitCurrentFullScreenElement. Start the event timer.
>  3. When the timer fires, events are dispatched. If the tree has changed
>     since the events were enqueued, additional events may be fired.
> 
> And similarly for exit. For errors, requestFullscreen() would itself
> start the timer to fire the events.
> 
> Now, fullscreen requests will:
>  1. In Fullscreen::requestFullscreen(), append to a list of pending
>     requests.
>  2. When the resize happens, enqueue an animation frame task for each
>     pending request.
>  3. In the animation frame task, apply all changes, decide which events
>     to fire and then fire them.
> 
> TEST=run-webkit-tests fullscreen/ imported/wpt/fullscreen/
>      webkit_unit_tests --gtest_filter=*Fullscreen*
>      interactive_ui_tests
--gtest_filter=SitePerProcessInteractiveBrowserTest.Fullscreen*
> BUG=402376,402421
>
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
> 
> Committed: https://crrev.com/e1d42d636990425056ede44086ef49a1f8c6a0a5
> Cr-Commit-Position: refs/heads/master@{#439607}

TBR=mlamouri@chromium.org,alexmos@chromium.org,eae@chromium.org,esprehn@chrom...
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=402376,402421
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2654083006
Cr-Commit-Position: refs/heads/master@{#446643}
Committed:
https://chromium.googlesource.com/chromium/src/+/675e4f2fe55c349ac3ba67405c15...
==========

[commit-bot: I haz the power, 2017-01-27 11:06:13]

Committed patchset #4 (id:340001) as
https://chromium.googlesource.com/chromium/src/+/675e4f2fe55c349ac3ba67405c15...