third_party/WebKit/Source/modules/vr/VRDisplay.cpp - Issue 2654083006: Revert of Sync requestFullscreen() and exitFullscreen() algorithms with the spec

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/vr/VRDisplay.cpp

Issue 2654083006: Revert of Sync requestFullscreen() and exitFullscreen() algorithms with the spec (Closed)

Patch Set: add failing test expectations Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/modules/vr/VRDisplay.cpp

diff --git a/third_party/WebKit/Source/modules/vr/VRDisplay.cpp b/third_party/WebKit/Source/modules/vr/VRDisplay.cpp

index 900b0a264af724c97a8e73086f945556ab30f406..83d1488380ac8c6c57d9a3df0403174504e7c361 100644

--- a/third_party/WebKit/Source/modules/vr/VRDisplay.cpp

+++ b/third_party/WebKit/Source/modules/vr/VRDisplay.cpp

@@ -710,7 +710,7 @@ void VRDisplay::onFullscreenCheck(TimerBase*) {

// depend on the Fullscreen API to fake VR presentation, so this will

// become unnessecary. Until that point, though, this seems preferable to

// adding a bunch of notification plumbing to Fullscreen.

- if (!Fullscreen::isFullscreenElement(*m_layer.source())) {

+ if (!Fullscreen::isCurrentFullScreenElement(*m_layer.source())) {

// TODO(mthiesse): Due to asynchronous resizing, we might get kicked out of

// fullscreen when changing display parameters upon entering WebVR. So one

// time only, we reenter fullscreen after having left it; otherwise we exit