Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Issue 2658703006: Measure requestFullscreen() replacing the pending element (Closed)

Created:
3 years, 10 months ago by foolip
Modified:
3 years, 10 months ago
Reviewers:
Eric Willigers
CC:
chromium-reviews, sof, eae+blinkwatch, blink-reviews-dom_chromium.org, dglazkov+blink, asvitkine+watch_chromium.org, blink-reviews, rwlbuis
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Measure requestFullscreen() replacing the pending element This is to inform a possible spec change. If it virtually never happens, it might be possible to have a single pending element in the spec as well, which could simplify things somewhat. Review-Url: https://codereview.chromium.org/2658703006 Cr-Commit-Position: refs/heads/master@{#448710} Committed: https://chromium.googlesource.com/chromium/src/+/4196987e022db4f94e9c2fb566a1c8ac585420ab

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M third_party/WebKit/Source/core/dom/Fullscreen.cpp View 1 chunk +4 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/frame/UseCounter.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
foolip
PTAL at whole CL, it's pretty trivial.
3 years, 10 months ago (2017-01-27 09:28:06 UTC) #2
Eric Willigers
lgtm
3 years, 10 months ago (2017-01-27 09:55:28 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2658703006/20001
3 years, 10 months ago (2017-02-07 18:13:52 UTC) #10
commit-bot: I haz the power
3 years, 10 months ago (2017-02-07 20:06:50 UTC) #13
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/4196987e022db4f94e9c2fb566a1...

Powered by Google App Engine
This is Rietveld 408576698