Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Side by Side Diff: third_party/WebKit/Source/core/dom/Element.cpp

Issue 2654083006: Revert of Sync requestFullscreen() and exitFullscreen() algorithms with the spec (Closed)
Patch Set: add failing test expectations Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2001 Peter Kelly (pmk@post.com) 4 * (C) 2001 Peter Kelly (pmk@post.com)
5 * (C) 2001 Dirk Mueller (mueller@kde.org) 5 * (C) 2001 Dirk Mueller (mueller@kde.org)
6 * (C) 2007 David Smith (catfish.man@gmail.com) 6 * (C) 2007 David Smith (catfish.man@gmail.com)
7 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2012, 2013 Apple Inc. 7 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2012, 2013 Apple Inc.
8 * All rights reserved. 8 * All rights reserved.
9 * (C) 2007 Eric Seidel (eric@webkit.org) 9 * (C) 2007 Eric Seidel (eric@webkit.org)
10 * 10 *
(...skipping 1612 matching lines...) Expand 10 before | Expand all | Expand 10 after
1623 setIsInCanvasSubtree(true); 1623 setIsInCanvasSubtree(true);
1624 1624
1625 return InsertionDone; 1625 return InsertionDone;
1626 } 1626 }
1627 1627
1628 void Element::removedFrom(ContainerNode* insertionPoint) { 1628 void Element::removedFrom(ContainerNode* insertionPoint) {
1629 bool wasInDocument = insertionPoint->isConnected(); 1629 bool wasInDocument = insertionPoint->isConnected();
1630 1630
1631 DCHECK(!hasRareData() || !elementRareData()->hasPseudoElements()); 1631 DCHECK(!hasRareData() || !elementRareData()->hasPseudoElements());
1632 1632
1633 if (Fullscreen::isFullscreenElement(*this)) { 1633 if (Fullscreen::isCurrentFullScreenElement(*this)) {
1634 setContainsFullScreenElementOnAncestorsCrossingFrameBoundaries(false); 1634 setContainsFullScreenElementOnAncestorsCrossingFrameBoundaries(false);
1635 if (insertionPoint->isElementNode()) { 1635 if (insertionPoint->isElementNode()) {
1636 toElement(insertionPoint)->setContainsFullScreenElement(false); 1636 toElement(insertionPoint)->setContainsFullScreenElement(false);
1637 toElement(insertionPoint) 1637 toElement(insertionPoint)
1638 ->setContainsFullScreenElementOnAncestorsCrossingFrameBoundaries( 1638 ->setContainsFullScreenElementOnAncestorsCrossingFrameBoundaries(
1639 false); 1639 false);
1640 } 1640 }
1641 } 1641 }
1642 1642
1643 if (Fullscreen* fullscreen = Fullscreen::fromIfExists(document())) 1643 if (Fullscreen* fullscreen = Fullscreen::fromIfExists(document()))
(...skipping 2395 matching lines...) Expand 10 before | Expand all | Expand 10 after
4039 if (isUserActionElement()) 4039 if (isUserActionElement())
4040 return false; 4040 return false;
4041 if (!parentOrShadowHostElement()->childrenSupportStyleSharing()) 4041 if (!parentOrShadowHostElement()->childrenSupportStyleSharing())
4042 return false; 4042 return false;
4043 if (this == document().cssTarget()) 4043 if (this == document().cssTarget())
4044 return false; 4044 return false;
4045 if (isHTMLElement() && toHTMLElement(this)->hasDirectionAuto()) 4045 if (isHTMLElement() && toHTMLElement(this)->hasDirectionAuto())
4046 return false; 4046 return false;
4047 if (hasAnimations()) 4047 if (hasAnimations())
4048 return false; 4048 return false;
4049 if (Fullscreen::isFullscreenElement(*this)) 4049 if (Fullscreen::isCurrentFullScreenElement(*this))
4050 return false; 4050 return false;
4051 return true; 4051 return true;
4052 } 4052 }
4053 4053
4054 void Element::logAddElementIfIsolatedWorldAndInDocument( 4054 void Element::logAddElementIfIsolatedWorldAndInDocument(
4055 const char element[], 4055 const char element[],
4056 const QualifiedName& attr1) { 4056 const QualifiedName& attr1) {
4057 if (!isConnected()) 4057 if (!isConnected())
4058 return; 4058 return;
4059 V8DOMActivityLogger* activityLogger = 4059 V8DOMActivityLogger* activityLogger =
(...skipping 67 matching lines...) Expand 10 before | Expand all | Expand 10 after
4127 } 4127 }
4128 4128
4129 DEFINE_TRACE_WRAPPERS(Element) { 4129 DEFINE_TRACE_WRAPPERS(Element) {
4130 if (hasRareData()) { 4130 if (hasRareData()) {
4131 visitor->traceWrappers(elementRareData()); 4131 visitor->traceWrappers(elementRareData());
4132 } 4132 }
4133 ContainerNode::traceWrappers(visitor); 4133 ContainerNode::traceWrappers(visitor);
4134 } 4134 }
4135 4135
4136 } // namespace blink 4136 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/dom/DocumentFullscreen.idl ('k') | third_party/WebKit/Source/core/dom/Fullscreen.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698