[SPInvalidation] Update paint properties when full screen status changes

[SPInvalidation] Update paint properties when full screen status changes

BUG=645667
TEST=imported/wpt/fullscreen/api/element-ready-check-fullscreen-iframe-child-manual.html with --enable-slimming-paint-invalidation

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Committed: https://crrev.com/bf16f458a95911305740fc0310ebf3cd00830c91
Cr-Commit-Position: refs/heads/master@{#440312}

[Xianzhu, 2016-12-21 23:39:40]

The CQ bit was checked by wangxianzhu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-21 23:40:07]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Xianzhu, 2016-12-21 23:46:33]

wangxianzhu@chromium.org changed reviewers:
+ pdr@chromium.org

[Xianzhu, 2016-12-21 23:46:34]

https://codereview.chromium.org/2599573002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/frame/FrameView.cpp (right):

https://codereview.chromium.org/2599573002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/frame/FrameView.cpp:4017:
setNeedsPaintPropertyUpdate();
This is moved here because updateScrollbars() is called when scroll paint
properties may change, e.g. from setScrollbarMode() which affects
userScrollable(Horizontal|Vertical). Didn't find a failed case though.

[commit-bot: I haz the power, 2016-12-22 00:02:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-22 00:02:32]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[pdr., 2016-12-22 00:30:00]

Description was changed from

==========
[SPInvalidation] Update paint properties when full screen status changes

BUG=645667
TEST=imported/wpt/fullscreen/api/element-ready-check-fullscreen-iframe-child-manual.html
with --enable-slimming-paint-invalidation

x
==========

to

==========
[SPInvalidation] Update paint properties when full screen status changes

BUG=645667
TEST=imported/wpt/fullscreen/api/element-ready-check-fullscreen-iframe-child-manual.html
with --enable-slimming-paint-invalidation

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[pdr., 2016-12-22 00:37:16]

LGTM

https://codereview.chromium.org/2599573002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/dom/Fullscreen.cpp (right):

https://codereview.chromium.org/2599573002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/dom/Fullscreen.cpp:904:
frame->view()->setNeedsPaintPropertyUpdate();
nit: use the local variable:
if (FrameView* frameView = frame->view())
  frameView->setNeedsPaintPropertyUpdate();

[Xianzhu, 2016-12-22 00:45:23]

The CQ bit was checked by wangxianzhu@chromium.org

[Xianzhu, 2016-12-22 00:45:23]

The patchset sent to the CQ was uploaded after l-g-t-m from pdr@chromium.org
Link to the patchset: https://codereview.chromium.org/2599573002/#ps40001
(title: "Use local variable")

[Xianzhu, 2016-12-22 00:45:29]

https://codereview.chromium.org/2599573002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/dom/Fullscreen.cpp (right):

https://codereview.chromium.org/2599573002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/dom/Fullscreen.cpp:904:
frame->view()->setNeedsPaintPropertyUpdate();
On 2016/12/22 00:37:16, pdr (OOO Dec 23 to Jan 2) wrote:
> nit: use the local variable:
> if (FrameView* frameView = frame->view())
>   frameView->setNeedsPaintPropertyUpdate();

Done.

[commit-bot: I haz the power, 2016-12-22 00:45:43]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-22 02:06:19]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1482367523138360,
"parent_rev": "374f64c686916a5ab010972dc77c4355d2c3f747", "commit_rev":
"1f0ca2fc79a76c29d29873c1d8c2d4193623463a"}

[commit-bot: I haz the power, 2016-12-22 02:06:45]

Description was changed from

==========
[SPInvalidation] Update paint properties when full screen status changes

BUG=645667
TEST=imported/wpt/fullscreen/api/element-ready-check-fullscreen-iframe-child-manual.html
with --enable-slimming-paint-invalidation

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
[SPInvalidation] Update paint properties when full screen status changes

BUG=645667
TEST=imported/wpt/fullscreen/api/element-ready-check-fullscreen-iframe-child-manual.html
with --enable-slimming-paint-invalidation

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2599573002
==========

[commit-bot: I haz the power, 2016-12-22 02:06:46]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-12-22 02:10:22]

Description was changed from

==========
[SPInvalidation] Update paint properties when full screen status changes

BUG=645667
TEST=imported/wpt/fullscreen/api/element-ready-check-fullscreen-iframe-child-manual.html
with --enable-slimming-paint-invalidation

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2599573002
==========

to

==========
[SPInvalidation] Update paint properties when full screen status changes

BUG=645667
TEST=imported/wpt/fullscreen/api/element-ready-check-fullscreen-iframe-child-manual.html
with --enable-slimming-paint-invalidation

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Committed: https://crrev.com/bf16f458a95911305740fc0310ebf3cd00830c91
Cr-Commit-Position: refs/heads/master@{#440312}
==========

[commit-bot: I haz the power, 2016-12-22 02:10:23]

Patchset 3 (id:??) landed as
https://crrev.com/bf16f458a95911305740fc0310ebf3cd00830c91
Cr-Commit-Position: refs/heads/master@{#440312}