[Devtools] Added typing to network in prep for removing unrestricted

[Devtools] Added typing to network in prep for removing unrestricted

This patch adds the needed types to classes in order to remove
@unrestricted from all network classes.

R=pfeldman,luoe
BUG=681992
Review-Url: https://codereview.chromium.org/2653363002
Cr-Commit-Position: refs/heads/master@{#446590}
Committed: https://chromium.googlesource.com/chromium/src/+/3f08826decc8e8e5630a470cad33f0a967375b07

[allada, 2017-01-25 23:42:39]

The CQ bit was checked by allada@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-25 23:43:27]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[allada, 2017-01-25 23:47:42]

PTL

[pfeldman, 2017-01-25 23:54:18]

https://codereview.chromium.org/2653363002/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/network/RequestHeadersView.js
(right):

https://codereview.chromium.org/2653363002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/network/RequestHeadersView.js:502:
Network.RequestHeadersView._viewSourceSymbol = Symbol('ViewSource');
That does not look automated!

[allada, 2017-01-26 00:06:34]

https://codereview.chromium.org/2653363002/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/network/RequestHeadersView.js
(right):

https://codereview.chromium.org/2653363002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/network/RequestHeadersView.js:502:
Network.RequestHeadersView._viewSourceSymbol = Symbol('ViewSource');
On 2017/01/25 23:54:18, pfeldman wrote:
> That does not look automated!

This patch is not the automated stuff. This is the stuff my script cannot do.

[pfeldman, 2017-01-26 00:16:29]

That's two bugs right there for a questionable compilation strictness
improvement. Not sure we want to go for it at this cost.

https://codereview.chromium.org/2653363002/diff/1/third_party/WebKit/Source/d...
File
third_party/WebKit/Source/devtools/front_end/network/NetworkLogViewColumns.js
(right):

https://codereview.chromium.org/2653363002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/network/NetworkLogViewColumns.js:153:
if (!node || !request)
!node check might come a bit too late

https://codereview.chromium.org/2653363002/diff/1/third_party/WebKit/Source/d...
File
third_party/WebKit/Source/devtools/front_end/network/NetworkTimeCalculator.js
(right):

https://codereview.chromium.org/2653363002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/network/NetworkTimeCalculator.js:301:
if (typeof this._minimumBoundary === 'undefined' || typeof this._maximumBoundary
=== 'undefined') {
You just broke this.

https://codereview.chromium.org/2653363002/diff/1/third_party/WebKit/Source/d...
File
third_party/WebKit/Source/devtools/front_end/network/NetworkWaterfallColumn.js
(right):

https://codereview.chromium.org/2653363002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/network/NetworkWaterfallColumn.js:35:
this._startTime = this._calculator.minimumBoundary();
You are changing the logic here, now calculator is accessed before the update
(not sure it is bad, but it is different).

[commit-bot: I haz the power, 2017-01-26 01:15:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-26 01:15:05]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[allada, 2017-01-26 22:57:44]

PTaL. Yes, I agree. It does however, it's a one time payoff which will enforce
good coding style.

https://codereview.chromium.org/2653363002/diff/1/third_party/WebKit/Source/d...
File
third_party/WebKit/Source/devtools/front_end/network/NetworkLogViewColumns.js
(right):

https://codereview.chromium.org/2653363002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/network/NetworkLogViewColumns.js:153:
if (!node || !request)
On 2017/01/26 00:16:29, pfeldman wrote:
> !node check might come a bit too late

Done.

https://codereview.chromium.org/2653363002/diff/1/third_party/WebKit/Source/d...
File
third_party/WebKit/Source/devtools/front_end/network/NetworkTimeCalculator.js
(right):

https://codereview.chromium.org/2653363002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/network/NetworkTimeCalculator.js:301:
if (typeof this._minimumBoundary === 'undefined' || typeof this._maximumBoundary
=== 'undefined') {
On 2017/01/26 00:16:29, pfeldman wrote:
> You just broke this.

Done.

https://codereview.chromium.org/2653363002/diff/1/third_party/WebKit/Source/d...
File
third_party/WebKit/Source/devtools/front_end/network/NetworkWaterfallColumn.js
(right):

https://codereview.chromium.org/2653363002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/network/NetworkWaterfallColumn.js:35:
this._startTime = this._calculator.minimumBoundary();
On 2017/01/26 00:16:29, pfeldman wrote:
> You are changing the logic here, now calculator is accessed before the update
> (not sure it is bad, but it is different).

In this case it should not matter since the only time it is accessed without
being reset is in a popover, but it must have data by the time popover anchor
knows about ranges.

[pfeldman, 2017-01-27 00:02:25]

lgtm

[allada, 2017-01-27 00:12:28]

The CQ bit was checked by allada@chromium.org

[commit-bot: I haz the power, 2017-01-27 00:15:50]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[allada, 2017-01-27 01:05:00]

The CQ bit was unchecked by allada@chromium.org

[allada, 2017-01-27 01:05:05]

The CQ bit was checked by allada@chromium.org

[commit-bot: I haz the power, 2017-01-27 01:05:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-27 01:05:13]

Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)

[allada, 2017-01-27 03:39:14]

The CQ bit was checked by allada@chromium.org

[commit-bot: I haz the power, 2017-01-27 03:39:36]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-27 04:19:41]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1485488354792610,
"parent_rev": "89a16fd286b2d3a2d401c67916f6eb865ab93184", "commit_rev":
"3f08826decc8e8e5630a470cad33f0a967375b07"}

[commit-bot: I haz the power, 2017-01-27 04:20:32]

Description was changed from

==========
[Devtools] Added typing to network in prep for removing unrestricted

This patch adds the needed types to classes in order to remove
@unrestricted from all network classes.

R=pfeldman,luoe
BUG=681992
==========

to

==========
[Devtools] Added typing to network in prep for removing unrestricted

This patch adds the needed types to classes in order to remove
@unrestricted from all network classes.

R=pfeldman,luoe
BUG=681992

Review-Url: https://codereview.chromium.org/2653363002
Cr-Commit-Position: refs/heads/master@{#446590}
Committed:
https://chromium.googlesource.com/chromium/src/+/3f08826decc8e8e5630a470cad33...
==========

[commit-bot: I haz the power, 2017-01-27 04:20:33]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/3f08826decc8e8e5630a470cad33...