Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(718)

Unified Diff: third_party/WebKit/Source/devtools/front_end/network/RequestHeadersView.js

Issue 2653363002: [Devtools] Added typing to network in prep for removing unrestricted (Closed)
Patch Set: changes Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/network/NetworkWaterfallColumn.js ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/devtools/front_end/network/RequestHeadersView.js
diff --git a/third_party/WebKit/Source/devtools/front_end/network/RequestHeadersView.js b/third_party/WebKit/Source/devtools/front_end/network/RequestHeadersView.js
index 742ab309d0b83e5cdc7e9a1c58c7c0f88059709c..7b3231ed2135ab9e6e24c632be3af8758210e626 100644
--- a/third_party/WebKit/Source/devtools/front_end/network/RequestHeadersView.js
+++ b/third_party/WebKit/Source/devtools/front_end/network/RequestHeadersView.js
@@ -216,15 +216,16 @@ Network.RequestHeadersView = class extends UI.VBox {
* @this {Network.RequestHeadersView}
*/
function toggleViewSource(event) {
- paramsTreeElement._viewSource = !paramsTreeElement._viewSource;
+ paramsTreeElement[Network.RequestHeadersView._viewSourceSymbol] =
+ !paramsTreeElement[Network.RequestHeadersView._viewSourceSymbol];
this._refreshParams(title, params, sourceText, paramsTreeElement);
event.consume();
}
- paramsTreeElement.listItemElement.appendChild(
- this._createViewSourceToggle(paramsTreeElement._viewSource, toggleViewSource.bind(this)));
+ paramsTreeElement.listItemElement.appendChild(this._createViewSourceToggle(
+ paramsTreeElement[Network.RequestHeadersView._viewSourceSymbol], toggleViewSource.bind(this)));
- if (paramsTreeElement._viewSource) {
+ if (paramsTreeElement[Network.RequestHeadersView._viewSourceSymbol]) {
this._populateTreeElementWithSourceText(paramsTreeElement, sourceText);
return;
}
@@ -270,13 +271,15 @@ Network.RequestHeadersView = class extends UI.VBox {
* @this {Network.RequestHeadersView}
*/
function toggleViewSource(event) {
- treeElement._viewSource = !treeElement._viewSource;
+ treeElement[Network.RequestHeadersView._viewSourceSymbol] =
+ !treeElement[Network.RequestHeadersView._viewSourceSymbol];
this._refreshRequestJSONPayload(parsedObject, sourceText);
event.consume();
}
- listItem.appendChild(this._createViewSourceToggle(treeElement._viewSource, toggleViewSource.bind(this)));
- if (treeElement._viewSource) {
+ listItem.appendChild(this._createViewSourceToggle(
+ treeElement[Network.RequestHeadersView._viewSourceSymbol], toggleViewSource.bind(this)));
+ if (treeElement[Network.RequestHeadersView._viewSourceSymbol]) {
this._populateTreeElementWithSourceText(this._requestPayloadCategory, sourceText);
} else {
var object = SDK.RemoteObject.fromLocalObject(parsedObject);
@@ -496,6 +499,8 @@ Network.RequestHeadersView = class extends UI.VBox {
}
};
+Network.RequestHeadersView._viewSourceSymbol = Symbol('ViewSource');
+
/**
* @unrestricted
*/
« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/network/NetworkWaterfallColumn.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698