third_party/WebKit/Source/devtools/front_end/network/NetworkPanel.js - Issue 2653363002: [Devtools] Added typing to network in prep for removing unrestricted

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/network/NetworkPanel.js

Issue 2653363002: [Devtools] Added typing to network in prep for removing unrestricted (Closed)

Patch Set: changes Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/network/NetworkOverview.js ('k') | third_party/WebKit/Source/devtools/front_end/network/NetworkTimeCalculator.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/network/NetworkPanel.js

diff --git a/third_party/WebKit/Source/devtools/front_end/network/NetworkPanel.js b/third_party/WebKit/Source/devtools/front_end/network/NetworkPanel.js

index cfe3a2e4991ce1e717f2c8dd6c2620c6ff365065..92bc783dc85e750cad369f6dc11f4801c6169ae0 100644

--- a/third_party/WebKit/Source/devtools/front_end/network/NetworkPanel.js

+++ b/third_party/WebKit/Source/devtools/front_end/network/NetworkPanel.js

@@ -633,6 +633,8 @@ Network.NetworkPanel.FilmStripRecorder = class {

* @param {!PerfUI.FilmStripView} filmStripView

constructor(timeCalculator, filmStripView) {

+ /** @type {?SDK.Target} */

+ this._target = null;

this._timeCalculator = timeCalculator;

this._filmStripView = filmStripView;

}

@@ -656,7 +658,7 @@ Network.NetworkPanel.FilmStripRecorder = class {

* @override

tracingComplete() {

- if (!this._tracingModel)

+ if (!this._tracingModel || !this._target)

return;

this._tracingModel.tracingComplete();

SDK.targetManager.resumeReload(this._target);