third_party/WebKit/Source/devtools/front_end/network/NetworkTimeCalculator.js - Issue 2653363002: [Devtools] Added typing to network in prep for removing unrestricted

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/network/NetworkTimeCalculator.js

Issue 2653363002: [Devtools] Added typing to network in prep for removing unrestricted (Closed)

Patch Set: changes Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/network/NetworkPanel.js ('k') | third_party/WebKit/Source/devtools/front_end/network/NetworkWaterfallColumn.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/network/NetworkTimeCalculator.js

diff --git a/third_party/WebKit/Source/devtools/front_end/network/NetworkTimeCalculator.js b/third_party/WebKit/Source/devtools/front_end/network/NetworkTimeCalculator.js

index 26006cd5b9a16e8595e733c9954b8f7071b53532..05ceea8e50a22e8772385dd9ca7995efdfe3ec72 100644

--- a/third_party/WebKit/Source/devtools/front_end/network/NetworkTimeCalculator.js

+++ b/third_party/WebKit/Source/devtools/front_end/network/NetworkTimeCalculator.js

@@ -58,6 +58,8 @@ Network.NetworkTimeCalculator = class extends Common.Object {

constructor(startAtZero) {

super();

this.startAtZero = startAtZero;

+ this._minimumBoundary = -1;

+ this._maximumBoundary = -1;

this._boundryChangedEventThrottler = new Common.Throttler(0);

/** @type {?Network.NetworkTimeBoundary} */

this._window = null;

@@ -143,8 +145,8 @@ Network.NetworkTimeCalculator = class extends Common.Object {

}

reset() {

- delete this._minimumBoundary;

- delete this._maximumBoundary;

+ this._minimumBoundary = -1;

+ this._maximumBoundary = -1;

this._boundaryChanged();

}

@@ -296,7 +298,7 @@ Network.NetworkTimeCalculator = class extends Common.Object {

var previousMinimumBoundary = this._minimumBoundary;

var previousMaximumBoundary = this._maximumBoundary;

const minOffset = Network.NetworkTimeCalculator._minimumSpread;

- if (typeof this._minimumBoundary === 'undefined' || typeof this._maximumBoundary === 'undefined') {

+ if (this._minimumBoundary === -1 || this._maximumBoundary === -1) {

this._minimumBoundary = timestamp;

this._maximumBoundary = timestamp + minOffset;

} else {