Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(647)

Unified Diff: third_party/WebKit/Source/devtools/front_end/network/NetworkWaterfallColumn.js

Issue 2653363002: [Devtools] Added typing to network in prep for removing unrestricted (Closed)
Patch Set: changes Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/network/NetworkWaterfallColumn.js
diff --git a/third_party/WebKit/Source/devtools/front_end/network/NetworkWaterfallColumn.js b/third_party/WebKit/Source/devtools/front_end/network/NetworkWaterfallColumn.js
index b3140706dd7be591e4d296571194a161f1a16b7d..6eeb0baa381882e8be3e815780ca82b794925e3a 100644
--- a/third_party/WebKit/Source/devtools/front_end/network/NetworkWaterfallColumn.js
+++ b/third_party/WebKit/Source/devtools/front_end/network/NetworkWaterfallColumn.js
@@ -30,6 +30,11 @@ Network.NetworkWaterfallColumn = class extends UI.VBox {
this._headerHeight = 0;
this._calculator = calculator;
+ this._offsetWidth = 0;
+ this._offsetHeight = 0;
+ this._startTime = this._calculator.minimumBoundary();
+ this._endTime = this._calculator.maximumBoundary();
+
this._popoverHelper = new UI.PopoverHelper(this.element);
this._popoverHelper.initializeCallbacks(this._getPopoverAnchor.bind(this), this._showPopover.bind(this));
this._popoverHelper.setTimeout(300, 300);
@@ -214,8 +219,10 @@ Network.NetworkWaterfallColumn = class extends UI.VBox {
}
if (eventDividers !== undefined)
this._eventDividers = eventDividers;
- this.element.window().cancelAnimationFrame(this._updateRequestID);
- this._updateRequestID = null;
+ if (this._updateRequestID) {
+ this.element.window().cancelAnimationFrame(this._updateRequestID);
+ delete this._updateRequestID;
+ }
this._startTime = this._calculator.minimumBoundary();
this._endTime = this._calculator.maximumBoundary();

Powered by Google App Engine
This is Rietveld 408576698