Make StyleResolverState argument a pointer in maybeConvertValue()

Make StyleResolverState argument a pointer in CSSInterpolationType::maybeConvertValue()

There are very few scenarios where the StyleResolverState is required
to convert a CSSValue for animations. This patch makes passing in the
state optional in preparation for supporting animations on registered
custom properties which do not need access to the StyleResolverState.

BUG=681424
Review-Url: https://codereview.chromium.org/2651533005
Cr-Commit-Position: refs/heads/master@{#448203}
Committed: https://chromium.googlesource.com/chromium/src/+/aca84dc37eb032e7ed985a19597a233b6f491fcc

[alancutter (OOO until 2018), 2017-01-25 07:03:01]

Description was changed from

==========
Make StyleResolverState argument a pointer in maybeConvertValue()

BUG=681424
==========

to

==========
Make StyleResolverState argument a pointer in
CSSInterpolationType::maybeConvertValue()

There are very few scenarios where the StyleResolverState is required
to convert a CSSValue for animations. This patch makes passing in the
state optional in preparation for supporting animations on registered
custom properties.

BUG=681424
==========

[alancutter (OOO until 2018), 2017-01-25 07:03:02]

alancutter@chromium.org changed reviewers:
+ ericwilligers@chromium.org

[alancutter (OOO until 2018), 2017-01-25 07:05:28]

Description was changed from

==========
Make StyleResolverState argument a pointer in
CSSInterpolationType::maybeConvertValue()

There are very few scenarios where the StyleResolverState is required
to convert a CSSValue for animations. This patch makes passing in the
state optional in preparation for supporting animations on registered
custom properties.

BUG=681424
==========

to

==========
Make StyleResolverState argument a pointer in
CSSInterpolationType::maybeConvertValue()

There are very few scenarios where the StyleResolverState is required
to convert a CSSValue for animations. This patch makes passing in the
state optional in preparation for supporting animations on registered
custom properties which do not need access to the StyleResolverState.

BUG=681424
==========

[Eric Willigers, 2017-01-25 21:54:06]

lgtm

https://codereview.chromium.org/2651533005/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/animation/CSSFontWeightInterpolationType.cpp
(right):

https://codereview.chromium.org/2651533005/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/animation/CSSFontWeightInterpolationType.cpp:115:
FontWeight inheritedFontWeight = state->parentStyle()->fontWeight();
DCHECK ?

[alancutter (OOO until 2018), 2017-01-30 23:03:20]

https://codereview.chromium.org/2651533005/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/animation/CSSFontWeightInterpolationType.cpp
(right):

https://codereview.chromium.org/2651533005/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/animation/CSSFontWeightInterpolationType.cpp:115:
FontWeight inheritedFontWeight = state->parentStyle()->fontWeight();
On 2017/01/25 at 21:54:06, Eric Willigers wrote:
> DCHECK ?

I don't think it's particularly necessary for things that would crash anyway.

[alancutter (OOO until 2018), 2017-01-30 23:04:10]

On 2017/01/30 at 23:03:20, alancutter wrote:
>
https://codereview.chromium.org/2651533005/diff/1/third_party/WebKit/Source/c...
> File
third_party/WebKit/Source/core/animation/CSSFontWeightInterpolationType.cpp
(right):
> 
>
https://codereview.chromium.org/2651533005/diff/1/third_party/WebKit/Source/c...
>
third_party/WebKit/Source/core/animation/CSSFontWeightInterpolationType.cpp:115:
FontWeight inheritedFontWeight = state->parentStyle()->fontWeight();
> On 2017/01/25 at 21:54:06, Eric Willigers wrote:
> > DCHECK ?
> 
> I don't think it's particularly necessary for things that would crash anyway.

I suppose it makes it clear that it's the intention and not a mistake, will do.

[alancutter (OOO until 2018), 2017-01-30 23:19:08]

The CQ bit was checked by alancutter@chromium.org

[alancutter (OOO until 2018), 2017-01-30 23:19:09]

The patchset sent to the CQ was uploaded after l-g-t-m from
ericwilligers@chromium.org
Link to the patchset: https://codereview.chromium.org/2651533005/#ps20001
(title: "DCHECK")

[commit-bot: I haz the power, 2017-01-30 23:19:53]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-30 23:23:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-30 23:23:33]

Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)

[alancutter (OOO until 2018), 2017-02-06 00:35:38]

The CQ bit was checked by alancutter@chromium.org

[alancutter (OOO until 2018), 2017-02-06 00:35:38]

The patchset sent to the CQ was uploaded after l-g-t-m from
ericwilligers@chromium.org
Link to the patchset: https://codereview.chromium.org/2651533005/#ps40001
(title: "Rebased")

[commit-bot: I haz the power, 2017-02-06 00:35:52]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-06 02:16:36]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1486341338084160,
"parent_rev": "beb5158bcaf3a72957e6f14873ec439c737d5c6e", "commit_rev":
"aca84dc37eb032e7ed985a19597a233b6f491fcc"}

[commit-bot: I haz the power, 2017-02-06 02:17:43]

Description was changed from

==========
Make StyleResolverState argument a pointer in
CSSInterpolationType::maybeConvertValue()

There are very few scenarios where the StyleResolverState is required
to convert a CSSValue for animations. This patch makes passing in the
state optional in preparation for supporting animations on registered
custom properties which do not need access to the StyleResolverState.

BUG=681424
==========

to

==========
Make StyleResolverState argument a pointer in
CSSInterpolationType::maybeConvertValue()

There are very few scenarios where the StyleResolverState is required
to convert a CSSValue for animations. This patch makes passing in the
state optional in preparation for supporting animations on registered
custom properties which do not need access to the StyleResolverState.

BUG=681424

Review-Url: https://codereview.chromium.org/2651533005
Cr-Commit-Position: refs/heads/master@{#448203}
Committed:
https://chromium.googlesource.com/chromium/src/+/aca84dc37eb032e7ed985a19597a...
==========

[commit-bot: I haz the power, 2017-02-06 02:17:44]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/aca84dc37eb032e7ed985a19597a...