third_party/WebKit/Source/core/animation/CSSColorInterpolationType.cpp - Issue 2651533005: Make StyleResolverState argument a pointer in maybeConvertValue()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/animation/CSSColorInterpolationType.cpp

Issue 2651533005: Make StyleResolverState argument a pointer in maybeConvertValue() (Closed)

Patch Set: Rebased Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/animation/CSSColorInterpolationType.h ('k') | third_party/WebKit/Source/core/animation/CSSFilterListInterpolationType.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/animation/CSSColorInterpolationType.cpp

diff --git a/third_party/WebKit/Source/core/animation/CSSColorInterpolationType.cpp b/third_party/WebKit/Source/core/animation/CSSColorInterpolationType.cpp

index ef834b9901f66bc7c9069ab54edd64237f68db44..8d16321df5192719b452309bc0f6cbb7b0564b5a 100644

--- a/third_party/WebKit/Source/core/animation/CSSColorInterpolationType.cpp

+++ b/third_party/WebKit/Source/core/animation/CSSColorInterpolationType.cpp

@@ -212,11 +212,13 @@ enum InterpolableColorPairIndex : unsigned {

InterpolationValue CSSColorInterpolationType::maybeConvertValue(

const CSSValue& value,

- const StyleResolverState& state,

+ const StyleResolverState* state,

ConversionCheckers& conversionCheckers) const {

if (cssProperty() == CSSPropertyColor && value.isIdentifierValue() &&

- toCSSIdentifierValue(value).getValueID() == CSSValueCurrentcolor)

- return maybeConvertInherit(state, conversionCheckers);

+ toCSSIdentifierValue(value).getValueID() == CSSValueCurrentcolor) {

+ DCHECK(state);

+ return maybeConvertInherit(*state, conversionCheckers);

+ }

std::unique_ptr<InterpolableValue> interpolableColor =

maybeCreateInterpolableColor(value);