Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Unified Diff: third_party/WebKit/Source/core/animation/CSSTransformInterpolationType.cpp

Issue 2651533005: Make StyleResolverState argument a pointer in maybeConvertValue() (Closed)
Patch Set: Rebased Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/animation/CSSTransformInterpolationType.cpp
diff --git a/third_party/WebKit/Source/core/animation/CSSTransformInterpolationType.cpp b/third_party/WebKit/Source/core/animation/CSSTransformInterpolationType.cpp
index 8e7fc5d24d75e5060c3dbdd4bc7ca372d63c8f4f..1a274d39567c4a9e8bef41c877ce759506617395 100644
--- a/third_party/WebKit/Source/core/animation/CSSTransformInterpolationType.cpp
+++ b/third_party/WebKit/Source/core/animation/CSSTransformInterpolationType.cpp
@@ -175,8 +175,9 @@ InterpolationValue CSSTransformInterpolationType::maybeConvertInherit(
InterpolationValue CSSTransformInterpolationType::maybeConvertValue(
const CSSValue& value,
- const StyleResolverState& state,
+ const StyleResolverState* state,
ConversionCheckers& conversionCheckers) const {
+ DCHECK(state);
if (value.isValueList()) {
CSSLengthArray lengthArray;
for (const CSSValue* item : toCSSValueList(value)) {
@@ -195,14 +196,15 @@ InterpolationValue CSSTransformInterpolationType::maybeConvertValue(
}
}
std::unique_ptr<InterpolationType::ConversionChecker> lengthUnitsChecker =
- LengthUnitsChecker::maybeCreate(std::move(lengthArray), state);
+ LengthUnitsChecker::maybeCreate(std::move(lengthArray), *state);
if (lengthUnitsChecker)
conversionCheckers.push_back(std::move(lengthUnitsChecker));
}
+ DCHECK(state);
TransformOperations transform = TransformBuilder::createTransformOperations(
- value, state.cssToLengthConversionData());
+ value, state->cssToLengthConversionData());
return convertTransform(std::move(transform));
}

Powered by Google App Engine
This is Rietveld 408576698