Make maybeConvertStandardUnderlyingValue take a ComputedStyle instead of StyleResolverState

Make maybeConvertStandardUnderlyingValue() take a ComputedStyle instead of StyleResolverState

This change removes the dependency on StyleResolverState from underlying
value conversion logic in CSSInterpolationType. This is in preparation
for CSS Transitions using InterpolationTypes where there's no such
StyleResolverState available to construct the InterpolationValues.

BUG=681424
Review-Url: https://codereview.chromium.org/2657553003
Cr-Commit-Position: refs/heads/master@{#448464}
Committed: https://chromium.googlesource.com/chromium/src/+/3cd8efe88167f61d41362d233d6d2e04986f83f0

[alancutter (OOO until 2018), 2017-01-25 07:08:40]

Description was changed from

==========
Make maybeConvertStandardUnderlyingValue take a ComputedStyle instead of
StyleResolverState

BUG=681424
==========

to

==========
Make maybeConvertStandardUnderlyingValue() take a ComputedStyle instead of
StyleResolverState

This change removes the dependency on StyleResolverState from underlying
value conversion logic in CSSInterpolationType. This is in preparation
for CSS Transitions using InterpolationTypes where there's no such
StyleResolverState available to construct the InterpolationValues.

BUG=681424
==========

[alancutter (OOO until 2018), 2017-01-25 07:08:40]

alancutter@chromium.org changed reviewers:
+ ericwilligers@chromium.org

[Eric Willigers, 2017-01-25 21:53:14]

lgtm

https://codereview.chromium.org/2657553003/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/animation/CSSInterpolationType.cpp (right):

https://codereview.chromium.org/2657553003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/animation/CSSInterpolationType.cpp:251: return
maybeConvertStandardPropertyUnderlyingValue(*state.style());
DCHECK ?

[alancutter (OOO until 2018), 2017-01-28 21:08:29]

https://codereview.chromium.org/2657553003/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/animation/CSSInterpolationType.cpp (right):

https://codereview.chromium.org/2657553003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/animation/CSSInterpolationType.cpp:251: return
maybeConvertStandardPropertyUnderlyingValue(*state.style());
On 2017/01/25 at 21:53:14, Eric Willigers wrote:
> DCHECK ?

I don't think there's a code path where style is null. There's less need to
DCHECK on null dereferences as they'll crash anyway. This particular dereference
assumption is made all throughout the interpolation code.
I'll see if I can make this accessor return a reference instead in a separate
patch.

[alancutter (OOO until 2018), 2017-02-06 00:40:38]

The CQ bit was checked by alancutter@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-06 00:40:45]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-06 02:26:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-06 02:26:21]

Dry run: This issue passed the CQ dry run.

[alancutter (OOO until 2018), 2017-02-07 00:20:29]

The CQ bit was checked by alancutter@chromium.org

[alancutter (OOO until 2018), 2017-02-07 00:20:30]

The patchset sent to the CQ was uploaded after l-g-t-m from
ericwilligers@chromium.org
Link to the patchset: https://codereview.chromium.org/2657553003/#ps40001
(title: "Rebased")

[commit-bot: I haz the power, 2017-02-07 00:21:43]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-07 00:29:22]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1486426829983040,
"parent_rev": "dc062b30eac5feb37dcdc824cdf114b2aa30d77e", "commit_rev":
"3cd8efe88167f61d41362d233d6d2e04986f83f0"}

[commit-bot: I haz the power, 2017-02-07 00:30:03]

Description was changed from

==========
Make maybeConvertStandardUnderlyingValue() take a ComputedStyle instead of
StyleResolverState

This change removes the dependency on StyleResolverState from underlying
value conversion logic in CSSInterpolationType. This is in preparation
for CSS Transitions using InterpolationTypes where there's no such
StyleResolverState available to construct the InterpolationValues.

BUG=681424
==========

to

==========
Make maybeConvertStandardUnderlyingValue() take a ComputedStyle instead of
StyleResolverState

This change removes the dependency on StyleResolverState from underlying
value conversion logic in CSSInterpolationType. This is in preparation
for CSS Transitions using InterpolationTypes where there's no such
StyleResolverState available to construct the InterpolationValues.

BUG=681424

Review-Url: https://codereview.chromium.org/2657553003
Cr-Commit-Position: refs/heads/master@{#448464}
Committed:
https://chromium.googlesource.com/chromium/src/+/3cd8efe88167f61d41362d233d6d...
==========

[commit-bot: I haz the power, 2017-02-07 00:30:05]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/3cd8efe88167f61d41362d233d6d...