third_party/WebKit/Source/core/animation/CSSFontWeightInterpolationType.cpp - Issue 2651533005: Make StyleResolverState argument a pointer in maybeConvertValue()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/animation/CSSFontWeightInterpolationType.cpp

Issue 2651533005: Make StyleResolverState argument a pointer in maybeConvertValue() (Closed)

Patch Set: Rebased Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/animation/CSSFontWeightInterpolationType.h ('k') | third_party/WebKit/Source/core/animation/CSSImageInterpolationType.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/animation/CSSFontWeightInterpolationType.cpp

diff --git a/third_party/WebKit/Source/core/animation/CSSFontWeightInterpolationType.cpp b/third_party/WebKit/Source/core/animation/CSSFontWeightInterpolationType.cpp

index 1c5c182cf0ceb9df1cbb625eeafc3f79f8c81636..910b7ca79490a1aa7861b2f185207c532e7d9e94 100644

--- a/third_party/WebKit/Source/core/animation/CSSFontWeightInterpolationType.cpp

+++ b/third_party/WebKit/Source/core/animation/CSSFontWeightInterpolationType.cpp

@@ -98,7 +98,7 @@ InterpolationValue CSSFontWeightInterpolationType::maybeConvertInherit(

InterpolationValue CSSFontWeightInterpolationType::maybeConvertValue(

const CSSValue& value,

- const StyleResolverState& state,

+ const StyleResolverState* state,

ConversionCheckers& conversionCheckers) const {

if (!value.isIdentifierValue())

return nullptr;

@@ -112,7 +112,8 @@ InterpolationValue CSSFontWeightInterpolationType::maybeConvertValue(

case CSSValueBolder:

case CSSValueLighter: {

- FontWeight inheritedFontWeight = state.parentStyle()->fontWeight();

+ DCHECK(state);

+ FontWeight inheritedFontWeight = state->parentStyle()->fontWeight();

conversionCheckers.push_back(

InheritedFontWeightChecker::create(inheritedFontWeight));

if (keyword == CSSValueBolder)