Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(433)

Issue 2629593003: [Chromoting.com] Make Android telemetry report host version/os/os version (Closed)

Created:
3 years, 11 months ago by Yuwei
Modified:
3 years, 11 months ago
Reviewers:
*Sergey Ulanov, kelvinp
CC:
chromium-reviews, agrieve+watch_chromium.org, chromoting-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Chromoting.com] Make Android telemetry report host version/os/os version Previously the host telemetry logger doesn't report these information. This CL fixes this problem so that we can use host info to filter stats. BUG=680644 Review-Url: https://codereview.chromium.org/2629593003 Cr-Commit-Position: refs/heads/master@{#443481} Committed: https://chromium.googlesource.com/chromium/src/+/c8bf2f02a0eca1ab4d9ad73dd376172f8f95c5b5

Patch Set 1 #

Patch Set 2 : PTAL Point #

Total comments: 10

Patch Set 3 : PTAL Point #

Total comments: 2

Patch Set 4 : PTAL Point #

Unified diffs Side-by-side diffs Delta from patch set Stats (+124 lines, -16 lines) Patch
M remoting/android/java/src/org/chromium/chromoting/HostInfo.java View 5 chunks +11 lines, -4 lines 0 comments Download
M remoting/android/java/src/org/chromium/chromoting/SessionConnector.java View 1 chunk +2 lines, -1 line 0 comments Download
M remoting/android/java/src/org/chromium/chromoting/jni/Client.java View 3 chunks +4 lines, -3 lines 0 comments Download
M remoting/base/chromoting_event.h View 1 2 2 chunks +6 lines, -0 lines 0 comments Download
M remoting/base/chromoting_event.cc View 1 2 3 3 chunks +25 lines, -0 lines 0 comments Download
M remoting/client/client_telemetry_logger.h View 1 2 3 chunks +10 lines, -0 lines 0 comments Download
M remoting/client/client_telemetry_logger.cc View 2 chunks +19 lines, -0 lines 0 comments Download
M remoting/client/jni/chromoting_jni_instance.h View 1 2 chunks +9 lines, -1 line 0 comments Download
M remoting/client/jni/chromoting_jni_instance.cc View 1 2 4 chunks +12 lines, -1 line 0 comments Download
M remoting/client/jni/jni_client.h View 1 2 3 chunks +9 lines, -2 lines 0 comments Download
M remoting/client/jni/jni_client.cc View 1 4 chunks +17 lines, -4 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
Yuwei
PTAL
3 years, 11 months ago (2017-01-13 00:08:19 UTC) #3
Sergey Ulanov
https://codereview.chromium.org/2629593003/diff/20001/remoting/base/chromoting_event.cc File remoting/base/chromoting_event.cc (right): https://codereview.chromium.org/2629593003/diff/20001/remoting/base/chromoting_event.cc#newcode129 remoting/base/chromoting_event.cc:129: std::string lowerOs = base::ToLowerASCII(os); lower_os https://codereview.chromium.org/2629593003/diff/20001/remoting/base/chromoting_event.h File remoting/base/chromoting_event.h (right): ...
3 years, 11 months ago (2017-01-13 00:23:17 UTC) #4
Yuwei
PTAL https://codereview.chromium.org/2629593003/diff/20001/remoting/base/chromoting_event.cc File remoting/base/chromoting_event.cc (right): https://codereview.chromium.org/2629593003/diff/20001/remoting/base/chromoting_event.cc#newcode129 remoting/base/chromoting_event.cc:129: std::string lowerOs = base::ToLowerASCII(os); On 2017/01/13 00:23:17, Sergey ...
3 years, 11 months ago (2017-01-13 01:51:12 UTC) #5
Sergey Ulanov
lgtm https://codereview.chromium.org/2629593003/diff/40001/remoting/base/chromoting_event.cc File remoting/base/chromoting_event.cc (right): https://codereview.chromium.org/2629593003/diff/40001/remoting/base/chromoting_event.cc#newcode130 remoting/base/chromoting_event.cc:130: if (lower_os == "linux") { FYI there are ...
3 years, 11 months ago (2017-01-13 02:15:26 UTC) #6
Yuwei
Thanks! https://codereview.chromium.org/2629593003/diff/40001/remoting/base/chromoting_event.cc File remoting/base/chromoting_event.cc (right): https://codereview.chromium.org/2629593003/diff/40001/remoting/base/chromoting_event.cc#newcode130 remoting/base/chromoting_event.cc:130: if (lower_os == "linux") { On 2017/01/13 02:15:26, ...
3 years, 11 months ago (2017-01-13 02:27:21 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2629593003/60001
3 years, 11 months ago (2017-01-13 02:28:47 UTC) #10
commit-bot: I haz the power
3 years, 11 months ago (2017-01-13 03:51:28 UTC) #13
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/c8bf2f02a0eca1ab4d9ad73dd376...

Powered by Google App Engine
This is Rietveld 408576698