Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(206)

Side by Side Diff: remoting/client/jni/jni_client.cc

Issue 2629593003: [Chromoting.com] Make Android telemetry report host version/os/os version (Closed)
Patch Set: PTAL Point Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « remoting/client/jni/jni_client.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "remoting/client/jni/jni_client.h" 5 #include "remoting/client/jni/jni_client.h"
6 6
7 #include "base/android/jni_android.h" 7 #include "base/android/jni_android.h"
8 #include "base/android/jni_string.h" 8 #include "base/android/jni_string.h"
9 #include "base/logging.h" 9 #include "base/logging.h"
10 #include "jni/Client_jni.h" 10 #include "jni/Client_jni.h"
(...skipping 28 matching lines...) Expand all
39 } 39 }
40 40
41 void JniClient::ConnectToHost(const std::string& username, 41 void JniClient::ConnectToHost(const std::string& username,
42 const std::string& auth_token, 42 const std::string& auth_token,
43 const std::string& host_jid, 43 const std::string& host_jid,
44 const std::string& host_id, 44 const std::string& host_id,
45 const std::string& host_pubkey, 45 const std::string& host_pubkey,
46 const std::string& pairing_id, 46 const std::string& pairing_id,
47 const std::string& pairing_secret, 47 const std::string& pairing_secret,
48 const std::string& capabilities, 48 const std::string& capabilities,
49 const std::string& flags) { 49 const std::string& flags,
50 const std::string& host_version,
51 const std::string& host_os,
52 const std::string& host_os_version) {
50 DCHECK(runtime_->ui_task_runner()->BelongsToCurrentThread()); 53 DCHECK(runtime_->ui_task_runner()->BelongsToCurrentThread());
51 DCHECK(!display_handler_); 54 DCHECK(!display_handler_);
52 DCHECK(!session_); 55 DCHECK(!session_);
53 DCHECK(!secret_fetcher_); 56 DCHECK(!secret_fetcher_);
54 display_handler_.reset(new JniGlDisplayHandler(runtime_, java_client_)); 57 display_handler_.reset(new JniGlDisplayHandler(runtime_, java_client_));
55 secret_fetcher_.reset(new JniPairingSecretFetcher(runtime_, GetWeakPtr(), 58 secret_fetcher_.reset(new JniPairingSecretFetcher(runtime_, GetWeakPtr(),
56 host_id)); 59 host_id));
60 // TODO(BUG 680752): Create ClientTelemetryLogger here. No need to pass host
61 // info all the way down. Currently we have to do that due to thread
62 // restriction.
57 session_.reset(new ChromotingJniInstance( 63 session_.reset(new ChromotingJniInstance(
58 runtime_, GetWeakPtr(), secret_fetcher_->GetWeakPtr(), 64 runtime_, GetWeakPtr(), secret_fetcher_->GetWeakPtr(),
59 display_handler_->CreateCursorShapeStub(), 65 display_handler_->CreateCursorShapeStub(),
60 display_handler_->CreateVideoRenderer(), 66 display_handler_->CreateVideoRenderer(),
61 username, auth_token, host_jid, host_id, 67 username, auth_token, host_jid, host_id,
62 host_pubkey, pairing_id, pairing_secret, capabilities, flags)); 68 host_pubkey, pairing_id, pairing_secret, capabilities, flags,
69 host_version, host_os, host_os_version));
63 session_->Connect(); 70 session_->Connect();
64 } 71 }
65 72
66 void JniClient::DisconnectFromHost() { 73 void JniClient::DisconnectFromHost() {
67 DCHECK(runtime_->ui_task_runner()->BelongsToCurrentThread()); 74 DCHECK(runtime_->ui_task_runner()->BelongsToCurrentThread());
68 if (session_) { 75 if (session_) {
69 session_->Disconnect(); 76 session_->Disconnect();
70 runtime_->network_task_runner()->DeleteSoon(FROM_HERE, 77 runtime_->network_task_runner()->DeleteSoon(FROM_HERE,
71 session_.release()); 78 session_.release());
72 } 79 }
(...skipping 78 matching lines...) Expand 10 before | Expand all | Expand 10 after
151 JNIEnv* env, 158 JNIEnv* env,
152 const base::android::JavaParamRef<jobject>& caller, 159 const base::android::JavaParamRef<jobject>& caller,
153 const base::android::JavaParamRef<jstring>& username, 160 const base::android::JavaParamRef<jstring>& username,
154 const base::android::JavaParamRef<jstring>& authToken, 161 const base::android::JavaParamRef<jstring>& authToken,
155 const base::android::JavaParamRef<jstring>& hostJid, 162 const base::android::JavaParamRef<jstring>& hostJid,
156 const base::android::JavaParamRef<jstring>& hostId, 163 const base::android::JavaParamRef<jstring>& hostId,
157 const base::android::JavaParamRef<jstring>& hostPubkey, 164 const base::android::JavaParamRef<jstring>& hostPubkey,
158 const base::android::JavaParamRef<jstring>& pairId, 165 const base::android::JavaParamRef<jstring>& pairId,
159 const base::android::JavaParamRef<jstring>& pairSecret, 166 const base::android::JavaParamRef<jstring>& pairSecret,
160 const base::android::JavaParamRef<jstring>& capabilities, 167 const base::android::JavaParamRef<jstring>& capabilities,
161 const base::android::JavaParamRef<jstring>& flags) { 168 const base::android::JavaParamRef<jstring>& flags,
169 const base::android::JavaParamRef<jstring>& host_version,
170 const base::android::JavaParamRef<jstring>& host_os,
171 const base::android::JavaParamRef<jstring>& host_os_version) {
162 ConnectToHost(ConvertJavaStringToUTF8(env, username), 172 ConnectToHost(ConvertJavaStringToUTF8(env, username),
163 ConvertJavaStringToUTF8(env, authToken), 173 ConvertJavaStringToUTF8(env, authToken),
164 ConvertJavaStringToUTF8(env, hostJid), 174 ConvertJavaStringToUTF8(env, hostJid),
165 ConvertJavaStringToUTF8(env, hostId), 175 ConvertJavaStringToUTF8(env, hostId),
166 ConvertJavaStringToUTF8(env, hostPubkey), 176 ConvertJavaStringToUTF8(env, hostPubkey),
167 ConvertJavaStringToUTF8(env, pairId), 177 ConvertJavaStringToUTF8(env, pairId),
168 ConvertJavaStringToUTF8(env, pairSecret), 178 ConvertJavaStringToUTF8(env, pairSecret),
169 ConvertJavaStringToUTF8(env, capabilities), 179 ConvertJavaStringToUTF8(env, capabilities),
170 ConvertJavaStringToUTF8(env, flags)); 180 ConvertJavaStringToUTF8(env, flags),
181 ConvertJavaStringToUTF8(env, host_version),
182 ConvertJavaStringToUTF8(env, host_os),
183 ConvertJavaStringToUTF8(env, host_os_version));
171 } 184 }
172 185
173 void JniClient::Disconnect(JNIEnv* env, 186 void JniClient::Disconnect(JNIEnv* env,
174 const base::android::JavaParamRef<jobject>& caller) { 187 const base::android::JavaParamRef<jobject>& caller) {
175 DisconnectFromHost(); 188 DisconnectFromHost();
176 } 189 }
177 190
178 void JniClient::AuthenticationResponse( 191 void JniClient::AuthenticationResponse(
179 JNIEnv* env, 192 JNIEnv* env,
180 const JavaParamRef<jobject>& caller, 193 const JavaParamRef<jobject>& caller,
(...skipping 105 matching lines...) Expand 10 before | Expand all | Expand 10 after
286 return weak_ptr_; 299 return weak_ptr_;
287 } 300 }
288 301
289 static jlong Init(JNIEnv* env, const JavaParamRef<jobject>& caller) { 302 static jlong Init(JNIEnv* env, const JavaParamRef<jobject>& caller) {
290 return reinterpret_cast<intptr_t>( 303 return reinterpret_cast<intptr_t>(
291 new JniClient(ChromotingJniRuntime::GetInstance(), 304 new JniClient(ChromotingJniRuntime::GetInstance(),
292 base::android::ScopedJavaGlobalRef<jobject>(env, caller))); 305 base::android::ScopedJavaGlobalRef<jobject>(env, caller)));
293 } 306 }
294 307
295 } // namespace remoting 308 } // namespace remoting
OLDNEW
« no previous file with comments | « remoting/client/jni/jni_client.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698