Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(451)

Unified Diff: remoting/client/jni/chromoting_jni_instance.h

Issue 2629593003: [Chromoting.com] Make Android telemetry report host version/os/os version (Closed)
Patch Set: PTAL Point Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « remoting/client/client_telemetry_logger.cc ('k') | remoting/client/jni/chromoting_jni_instance.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: remoting/client/jni/chromoting_jni_instance.h
diff --git a/remoting/client/jni/chromoting_jni_instance.h b/remoting/client/jni/chromoting_jni_instance.h
index f3647a15889dd4a61b0ebaf2f365580a12580d65..74c88aa0f6755256eec80ce297d4cc202bb126e6 100644
--- a/remoting/client/jni/chromoting_jni_instance.h
+++ b/remoting/client/jni/chromoting_jni_instance.h
@@ -58,7 +58,10 @@ class ChromotingJniInstance
const std::string& pairing_id,
const std::string& pairing_secret,
const std::string& capabilities,
- const std::string& flags);
+ const std::string& flags,
+ const std::string& host_version,
+ const std::string& host_os,
+ const std::string& host_os_version);
~ChromotingJniInstance() override;
@@ -197,6 +200,11 @@ class ChromotingJniInstance
// thread.
bool connected_ = false;
+ // TODO(BUG 680752): Remove these.
+ std::string host_version_;
+ std::string host_os_;
+ std::string host_os_version_;
+
base::WeakPtr<ChromotingJniInstance> weak_ptr_;
base::WeakPtrFactory<ChromotingJniInstance> weak_factory_;
« no previous file with comments | « remoting/client/client_telemetry_logger.cc ('k') | remoting/client/jni/chromoting_jni_instance.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698