Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(229)

Unified Diff: remoting/client/jni/jni_client.h

Issue 2629593003: [Chromoting.com] Make Android telemetry report host version/os/os version (Closed)
Patch Set: PTAL Point Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « remoting/client/jni/chromoting_jni_instance.cc ('k') | remoting/client/jni/jni_client.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: remoting/client/jni/jni_client.h
diff --git a/remoting/client/jni/jni_client.h b/remoting/client/jni/jni_client.h
index b5bbfeb94c69be5a863053280f076f22dfdcaeaa..412d2e8ba7db68ebe70bdcd305796e43fd1aeaa7 100644
--- a/remoting/client/jni/jni_client.h
+++ b/remoting/client/jni/jni_client.h
@@ -29,6 +29,7 @@ class JniClient {
base::android::ScopedJavaGlobalRef<jobject> java_client);
virtual ~JniClient();
+ // TODO(yuweih): Put these arguments into a struct.
// Initiates a connection with the specified host. To skip the attempt at
// pair-based authentication, leave |pairing_id| and |pairing_secret| as
// empty strings.
@@ -40,7 +41,10 @@ class JniClient {
const std::string& pairing_id,
const std::string& pairing_secret,
const std::string& capabilities,
- const std::string& flags);
+ const std::string& flags,
+ const std::string& host_version,
+ const std::string& host_os,
+ const std::string& host_os_version);
// Terminates any ongoing connection attempt and cleans up by nullifying
// |session_|. This is a no-op unless |session| is currently non-null.
@@ -87,7 +91,10 @@ class JniClient {
const base::android::JavaParamRef<jstring>& pairId,
const base::android::JavaParamRef<jstring>& pairSecret,
const base::android::JavaParamRef<jstring>& capabilities,
- const base::android::JavaParamRef<jstring>& flags);
+ const base::android::JavaParamRef<jstring>& flags,
+ const base::android::JavaParamRef<jstring>& host_version,
+ const base::android::JavaParamRef<jstring>& host_os,
+ const base::android::JavaParamRef<jstring>& host_os_version);
void Disconnect(JNIEnv* env,
const base::android::JavaParamRef<jobject>& caller);
« no previous file with comments | « remoting/client/jni/chromoting_jni_instance.cc ('k') | remoting/client/jni/jni_client.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698