Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(323)

Unified Diff: remoting/android/java/src/org/chromium/chromoting/jni/Client.java

Issue 2629593003: [Chromoting.com] Make Android telemetry report host version/os/os version (Closed)
Patch Set: PTAL Point Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: remoting/android/java/src/org/chromium/chromoting/jni/Client.java
diff --git a/remoting/android/java/src/org/chromium/chromoting/jni/Client.java b/remoting/android/java/src/org/chromium/chromoting/jni/Client.java
index 274d149d335d8b62d15231b2e1457e28aa9422eb..e98718d59b6071e01abd00a658f5fe686392a12b 100644
--- a/remoting/android/java/src/org/chromium/chromoting/jni/Client.java
+++ b/remoting/android/java/src/org/chromium/chromoting/jni/Client.java
@@ -89,7 +89,7 @@ public class Client implements InputStub {
/** Attempts to form a connection to the user-selected host. */
public void connectToHost(String username, String authToken, String hostJid,
String hostId, String hostPubkey, SessionAuthenticator authenticator, String flags,
- ConnectionListener listener) {
+ String hostVersion, String hostOs, String hostOsVersion, ConnectionListener listener) {
disconnectFromHost();
mConnectionListener = listener;
@@ -97,7 +97,7 @@ public class Client implements InputStub {
nativeConnect(mNativeJniClient, username, authToken, hostJid,
hostId, hostPubkey, mAuthenticator.getPairingId(hostId),
mAuthenticator.getPairingSecret(hostId), mCapabilityManager.getLocalCapabilities(),
- flags);
+ flags, hostVersion, hostOs, hostOsVersion);
mConnected = true;
}
@@ -296,7 +296,8 @@ public class Client implements InputStub {
/** Performs the native portion of the connection. */
private native void nativeConnect(long nativeJniClient,
String username, String authToken, String hostJid, String hostId, String hostPubkey,
- String pairId, String pairSecret, String capabilities, String flags);
+ String pairId, String pairSecret, String capabilities, String flags,
+ String hostVersion, String hostOs, String hostOsVersion);
/** Native implementation of Client.handleAuthenticationResponse(). */
private native void nativeAuthenticationResponse(
« no previous file with comments | « remoting/android/java/src/org/chromium/chromoting/SessionConnector.java ('k') | remoting/base/chromoting_event.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698