[i18n] chromeos login i18n-content to $i18n{}

[i18n] chromeos login i18n-content to $i18n{}

This is a semi-mechanical change to convert i18n-content to $i18n{}. The
Non-mechancal changes are some formatting adjustments.

BUG=677338
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2626123002
Cr-Commit-Position: refs/heads/master@{#443327}
Committed: https://chromium.googlesource.com/chromium/src/+/9dfcececdc896dd4be4d516de61d7f8bceebea99

[dschuyler, 2017-01-11 19:32:18]

Description was changed from

==========
[i18n] chromeos login i18n-content to $i18n{}

This is a semi-mechanical change to convert i18n-content to $i18n{}. The
Non-mechancal changes are some formatting adjustments.

BUG=477338
==========

to

==========
[i18n] chromeos login i18n-content to $i18n{}

This is a semi-mechanical change to convert i18n-content to $i18n{}. The
Non-mechancal changes are some formatting adjustments.

BUG=477338
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[dschuyler, 2017-01-11 19:32:20]

The CQ bit was checked by dschuyler@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-11 19:33:30]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-11 20:00:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-11 20:00:30]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[dschuyler, 2017-01-11 20:03:19]

The CQ bit was checked by dschuyler@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-11 20:03:44]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dschuyler, 2017-01-11 20:03:56]

Patchset #1 (id:1) has been deleted

[dschuyler, 2017-01-11 20:04:08]

dschuyler@chromium.org changed reviewers:
+ tommycli@chromium.org

[commit-bot: I haz the power, 2017-01-11 20:23:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-11 20:23:09]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[dschuyler, 2017-01-11 22:35:05]

Description was changed from

==========
[i18n] chromeos login i18n-content to $i18n{}

This is a semi-mechanical change to convert i18n-content to $i18n{}. The
Non-mechancal changes are some formatting adjustments.

BUG=477338
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
[i18n] chromeos login i18n-content to $i18n{}

This is a semi-mechanical change to convert i18n-content to $i18n{}. The
Non-mechancal changes are some formatting adjustments.

BUG=677338
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[tommycli, 2017-01-11 22:35:24]

On 2017/01/11 20:04:09, dschuyler wrote:

The test failures look related to these changes.

[dschuyler, 2017-01-11 22:47:02]

The CQ bit was checked by dschuyler@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-11 22:48:31]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dschuyler, 2017-01-11 22:48:38]

On 2017/01/11 22:35:24, tommycli wrote:
> On 2017/01/11 20:04:09, dschuyler wrote:
> 
> The test failures look related to these changes.

Yeah, there was an $i18n in a comment.

PTAL in the new patch.

[commit-bot: I haz the power, 2017-01-11 22:53:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-11 22:53:28]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[tommycli, 2017-01-11 22:55:41]

On 2017/01/11 22:48:38, dschuyler wrote:
> On 2017/01/11 22:35:24, tommycli wrote:
> > On 2017/01/11 20:04:09, dschuyler wrote:
> > 
> > The test failures look related to these changes.
> 
> Yeah, there was an $i18n in a comment.
> 
> PTAL in the new patch.

Need rebase i think

[dschuyler, 2017-01-11 23:15:39]

The CQ bit was checked by dschuyler@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-11 23:16:56]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dschuyler, 2017-01-11 23:24:29]

On 2017/01/11 22:55:41, tommycli wrote:
> On 2017/01/11 22:48:38, dschuyler wrote:
> > On 2017/01/11 22:35:24, tommycli wrote:
> > > On 2017/01/11 20:04:09, dschuyler wrote:
> > > 
> > > The test failures look related to these changes.
> > 
> > Yeah, there was an $i18n in a comment.
> > 
> > PTAL in the new patch.
> 
> Need rebase i think

I think so too. That should be done now.

[commit-bot: I haz the power, 2017-01-12 00:45:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-12 00:45:46]

Dry run: This issue passed the CQ dry run.

[tommycli, 2017-01-12 00:51:36]

lgtm except

https://codereview.chromium.org/2626123002/diff/60001/chrome/browser/resource...
File chrome/browser/resources/chromeos/login/oobe_screen_enable_debugging.html
(right):

https://codereview.chromium.org/2626123002/diff/60001/chrome/browser/resource...
chrome/browser/resources/chromeos/login/oobe_screen_enable_debugging.html:6:
done-specific wait-specific">
i think you need one more space here.

[dschuyler, 2017-01-12 01:17:43]

The CQ bit was checked by dschuyler@chromium.org to run a CQ dry run

[dschuyler, 2017-01-12 01:18:07]

https://codereview.chromium.org/2626123002/diff/60001/chrome/browser/resource...
File chrome/browser/resources/chromeos/login/oobe_screen_enable_debugging.html
(right):

https://codereview.chromium.org/2626123002/diff/60001/chrome/browser/resource...
chrome/browser/resources/chromeos/login/oobe_screen_enable_debugging.html:6:
done-specific wait-specific">
On 2017/01/12 00:51:36, tommycli wrote:
> i think you need one more space here.

Done.

[commit-bot: I haz the power, 2017-01-12 01:18:43]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-12 02:49:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-12 02:49:45]

Dry run: This issue passed the CQ dry run.

[dschuyler, 2017-01-12 19:27:41]

The CQ bit was checked by dschuyler@chromium.org

[dschuyler, 2017-01-12 19:27:42]

The patchset sent to the CQ was uploaded after l-g-t-m from
tommycli@chromium.org
Link to the patchset: https://codereview.chromium.org/2626123002/#ps80001
(title: "nit")

[commit-bot: I haz the power, 2017-01-12 19:28:30]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-12 19:41:05]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1484249261634090,
"parent_rev": "5b85620a5e701039630f96339a6d1b4ceb5b14f0", "commit_rev":
"9dfcececdc896dd4be4d516de61d7f8bceebea99"}

[commit-bot: I haz the power, 2017-01-12 19:41:43]

Description was changed from

==========
[i18n] chromeos login i18n-content to $i18n{}

This is a semi-mechanical change to convert i18n-content to $i18n{}. The
Non-mechancal changes are some formatting adjustments.

BUG=677338
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
[i18n] chromeos login i18n-content to $i18n{}

This is a semi-mechanical change to convert i18n-content to $i18n{}. The
Non-mechancal changes are some formatting adjustments.

BUG=677338
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2626123002
Cr-Commit-Position: refs/heads/master@{#443327}
Committed:
https://chromium.googlesource.com/chromium/src/+/9dfcececdc896dd4be4d516de61d...
==========

[commit-bot: I haz the power, 2017-01-12 19:41:47]

Committed patchset #4 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/9dfcececdc896dd4be4d516de61d...

[dschuyler, 2017-02-14 22:05:32]

A revert of this CL (patchset #4 id:80001) has been created in
https://codereview.chromium.org/2688413008/ by dschuyler@chromium.org.

The reason for reverting is: crbug/691904 reports that when changing the
language, the pages are not redrawn in the newly selected language. This CL is
not critical to get into M-57 so I'm reverting it to get a M-57 working asap. I
can look into it further for a later milestone..

[dschuyler, 2017-02-14 22:05:45]

A revert of this CL (patchset #4 id:80001) has been created in
https://codereview.chromium.org/2694353002/ by dschuyler@chromium.org.

The reason for reverting is: crbug/691904 reports that when changing the
language, the pages are not redrawn in the newly selected language. This CL is
not critical to get into M-57 so I'm reverting it to get a M-57 working asap. I
can look into it further for a later milestone..