Revert of [i18n] chromeos login i18n-content to $i18n{}

Revert of [i18n] chromeos login i18n-content to $i18n{} (patchset #4 id:80001 of https://codereview.chromium.org/2626123002/ )

Reason for revert:
crbug/691904 reports that when changing the language, the pages are not redrawn in the newly selected language. This CL is not critical to get into M-57 so I'm reverting it to get a M-57 working asap. I can look into it further for a later milestone.

Original issue's description:
> [i18n] chromeos login i18n-content to $i18n{}
> 
> This is a semi-mechanical change to convert i18n-content to $i18n{}. The
> Non-mechancal changes are some formatting adjustments.
> 
> BUG=677338
> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
> 
> Review-Url: https://codereview.chromium.org/2626123002
> Cr-Commit-Position: refs/heads/master@{#443327}
> Committed: https://chromium.googlesource.com/chromium/src/+/9dfcececdc896dd4be4d516de61d7f8bceebea99

TBR=tommycli@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=691904
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2694353002
Cr-Commit-Position: refs/heads/master@{#450762}
Committed: https://chromium.googlesource.com/chromium/src/+/8f21fb41278cc936a74fa33148ca01d394dd54a9

[dschuyler, 2017-02-14 22:05:45]

The CQ bit was checked by dschuyler@chromium.org

[dschuyler, 2017-02-14 22:05:46]

Created Revert of [i18n] chromeos login i18n-content to $i18n{}

[commit-bot: I haz the power, 2017-02-14 22:06:58]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-14 22:12:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-14 22:12:16]

Try jobs failed on following builders:
  android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)
  android_cronet on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_cron...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[dschuyler, 2017-02-14 22:18:27]

Description was changed from

==========
Revert of [i18n] chromeos login i18n-content to $i18n{} (patchset #4 id:80001 of
https://codereview.chromium.org/2626123002/ )

Reason for revert:
crbug/691904 reports that when changing the language, the pages are not redrawn
in the newly selected language. This CL is not critical to get into M-57 so I'm
reverting it to get a M-57 working asap. I can look into it further for a later
milestone.

Original issue's description:
> [i18n] chromeos login i18n-content to $i18n{}
> 
> This is a semi-mechanical change to convert i18n-content to $i18n{}. The
> Non-mechancal changes are some formatting adjustments.
> 
> BUG=677338
> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
> 
> Review-Url: https://codereview.chromium.org/2626123002
> Cr-Commit-Position: refs/heads/master@{#443327}
> Committed:
https://chromium.googlesource.com/chromium/src/+/9dfcececdc896dd4be4d516de61d...

TBR=tommycli@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=677338
==========

to

==========
Revert of [i18n] chromeos login i18n-content to $i18n{} (patchset #4 id:80001 of
https://codereview.chromium.org/2626123002/ )

Reason for revert:
crbug/691904 reports that when changing the language, the pages are not redrawn
in the newly selected language. This CL is not critical to get into M-57 so I'm
reverting it to get a M-57 working asap. I can look into it further for a later
milestone.

Original issue's description:
> [i18n] chromeos login i18n-content to $i18n{}
> 
> This is a semi-mechanical change to convert i18n-content to $i18n{}. The
> Non-mechancal changes are some formatting adjustments.
> 
> BUG=677338
> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
> 
> Review-Url: https://codereview.chromium.org/2626123002
> Cr-Commit-Position: refs/heads/master@{#443327}
> Committed:
https://chromium.googlesource.com/chromium/src/+/9dfcececdc896dd4be4d516de61d...

TBR=tommycli@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=691904
==========

[dschuyler, 2017-02-14 22:18:27]

dschuyler@chromium.org changed reviewers:
- tommycli@chromium.org

[dschuyler, 2017-02-14 22:20:04]

Description was changed from

==========
Revert of [i18n] chromeos login i18n-content to $i18n{} (patchset #4 id:80001 of
https://codereview.chromium.org/2626123002/ )

Reason for revert:
crbug/691904 reports that when changing the language, the pages are not redrawn
in the newly selected language. This CL is not critical to get into M-57 so I'm
reverting it to get a M-57 working asap. I can look into it further for a later
milestone.

Original issue's description:
> [i18n] chromeos login i18n-content to $i18n{}
> 
> This is a semi-mechanical change to convert i18n-content to $i18n{}. The
> Non-mechancal changes are some formatting adjustments.
> 
> BUG=677338
> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
> 
> Review-Url: https://codereview.chromium.org/2626123002
> Cr-Commit-Position: refs/heads/master@{#443327}
> Committed:
https://chromium.googlesource.com/chromium/src/+/9dfcececdc896dd4be4d516de61d...

TBR=tommycli@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=691904
==========

to

==========
Revert of [i18n] chromeos login i18n-content to $i18n{} (patchset #4 id:80001 of
https://codereview.chromium.org/2626123002/ )

Reason for revert:
crbug/691904 reports that when changing the language, the pages are not redrawn
in the newly selected language. This CL is not critical to get into M-57 so I'm
reverting it to get a M-57 working asap. I can look into it further for a later
milestone.

Original issue's description:
> [i18n] chromeos login i18n-content to $i18n{}
> 
> This is a semi-mechanical change to convert i18n-content to $i18n{}. The
> Non-mechancal changes are some formatting adjustments.
> 
> BUG=677338
> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
> 
> Review-Url: https://codereview.chromium.org/2626123002
> Cr-Commit-Position: refs/heads/master@{#443327}
> Committed:
https://chromium.googlesource.com/chromium/src/+/9dfcececdc896dd4be4d516de61d...

TBR=tommycli@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=691904
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[dschuyler, 2017-02-14 22:20:09]

The CQ bit was checked by dschuyler@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-14 22:20:42]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-14 22:24:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-14 22:24:22]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)

[dschuyler, 2017-02-14 22:32:30]

The CQ bit was checked by dschuyler@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-14 22:33:13]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dschuyler, 2017-02-14 22:34:11]

The CQ bit was checked by dschuyler@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-14 22:34:25]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dschuyler, 2017-02-14 22:34:34]

Patchset #2 (id:300001) has been deleted

[dschuyler, 2017-02-14 22:37:25]

The CQ bit was checked by dschuyler@chromium.org to run a CQ dry run

[dschuyler, 2017-02-14 22:37:46]

Patchset #2 (id:320001) has been deleted

[dschuyler, 2017-02-14 22:37:58]

Patchset #2 (id:340001) has been deleted

[commit-bot: I haz the power, 2017-02-14 22:38:20]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dschuyler, 2017-02-14 23:22:41]

The CQ bit was checked by dschuyler@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-14 23:23:05]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dschuyler, 2017-02-14 23:25:49]

Patchset #2 (id:360001) has been deleted

[dschuyler, 2017-02-14 23:33:07]

dschuyler@chromium.org changed reviewers:
+ stevenjb@chromium.org

[dschuyler, 2017-02-14 23:33:08]

Steven, most of this is a revert/rollback and can do with a skim over, but there
were some merges too. The oobe_welcome.html is where I did the most by-hand
merging.

[stevenjb, 2017-02-15 00:15:18]

I looked at the delta from PS1, and the absolute changes to oobe_welcome.html.

https://codereview.chromium.org/2694353002/diff/380001/chrome/browser/resourc...
File chrome/browser/resources/chromeos/login/oobe_buttons.html (right):

https://codereview.chromium.org/2694353002/diff/380001/chrome/browser/resourc...
chrome/browser/resources/chromeos/login/oobe_buttons.html:85: <div
id="text">$i18n{next}</div>
Recent $i18n{next} instance that needs fixing?

https://codereview.chromium.org/2694353002/diff/380001/chrome/browser/resourc...
File chrome/browser/resources/chromeos/login/oobe_welcome.html (right):

https://codereview.chromium.org/2694353002/diff/380001/chrome/browser/resourc...
chrome/browser/resources/chromeos/login/oobe_welcome.html:186:
aria-label="$i18n{timezoneDropdownTitle}">
$i18n{}

https://codereview.chromium.org/2694353002/diff/380001/chrome/browser/resourc...
File chrome/browser/resources/chromeos/login/oobe_welcome_dialog.html (right):

https://codereview.chromium.org/2694353002/diff/380001/chrome/browser/resourc...
chrome/browser/resources/chromeos/login/oobe_welcome_dialog.html:23:
$i18n{debuggingFeaturesLink}
$i18n{}

[dschuyler, 2017-02-15 00:36:19]

The CQ bit was checked by dschuyler@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-15 00:36:42]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dschuyler, 2017-02-15 01:13:53]

Thanks! I found some more new $i18n in controller-pairing-screen.html as well.

https://codereview.chromium.org/2694353002/diff/380001/chrome/browser/resourc...
File chrome/browser/resources/chromeos/login/oobe_buttons.html (right):

https://codereview.chromium.org/2694353002/diff/380001/chrome/browser/resourc...
chrome/browser/resources/chromeos/login/oobe_buttons.html:85: <div
id="text">$i18n{next}</div>
On 2017/02/15 00:15:18, stevenjb wrote:
> Recent $i18n{next} instance that needs fixing?

Done.

https://codereview.chromium.org/2694353002/diff/380001/chrome/browser/resourc...
File chrome/browser/resources/chromeos/login/oobe_welcome.html (right):

https://codereview.chromium.org/2694353002/diff/380001/chrome/browser/resourc...
chrome/browser/resources/chromeos/login/oobe_welcome.html:186:
aria-label="$i18n{timezoneDropdownTitle}">
On 2017/02/15 00:15:18, stevenjb wrote:
> $i18n{}

Done.

https://codereview.chromium.org/2694353002/diff/380001/chrome/browser/resourc...
File chrome/browser/resources/chromeos/login/oobe_welcome_dialog.html (right):

https://codereview.chromium.org/2694353002/diff/380001/chrome/browser/resourc...
chrome/browser/resources/chromeos/login/oobe_welcome_dialog.html:23:
$i18n{debuggingFeaturesLink}
On 2017/02/15 00:15:18, stevenjb wrote:
> $i18n{}

Done.

[dschuyler, 2017-02-15 01:14:15]

On 2017/02/15 01:13:53, dschuyler wrote:
> Thanks! I found some more new $i18n in controller-pairing-screen.html as well.
> 
>
https://codereview.chromium.org/2694353002/diff/380001/chrome/browser/resourc...
> File chrome/browser/resources/chromeos/login/oobe_buttons.html (right):
> 
>
https://codereview.chromium.org/2694353002/diff/380001/chrome/browser/resourc...
> chrome/browser/resources/chromeos/login/oobe_buttons.html:85: <div
> id="text">$i18n{next}</div>
> On 2017/02/15 00:15:18, stevenjb wrote:
> > Recent $i18n{next} instance that needs fixing?
> 
> Done.
> 
>
https://codereview.chromium.org/2694353002/diff/380001/chrome/browser/resourc...
> File chrome/browser/resources/chromeos/login/oobe_welcome.html (right):
> 
>
https://codereview.chromium.org/2694353002/diff/380001/chrome/browser/resourc...
> chrome/browser/resources/chromeos/login/oobe_welcome.html:186:
> aria-label="$i18n{timezoneDropdownTitle}">
> On 2017/02/15 00:15:18, stevenjb wrote:
> > $i18n{}
> 
> Done.
> 
>
https://codereview.chromium.org/2694353002/diff/380001/chrome/browser/resourc...
> File chrome/browser/resources/chromeos/login/oobe_welcome_dialog.html (right):
> 
>
https://codereview.chromium.org/2694353002/diff/380001/chrome/browser/resourc...
> chrome/browser/resources/chromeos/login/oobe_welcome_dialog.html:23:
> $i18n{debuggingFeaturesLink}
> On 2017/02/15 00:15:18, stevenjb wrote:
> > $i18n{}
> 
> Done.

Whoops, make that arc_terms_of_service.html.

[stevenjb, 2017-02-15 01:15:40]

lgtm

[commit-bot: I haz the power, 2017-02-15 03:55:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-15 03:55:31]

Dry run: This issue passed the CQ dry run.

[dschuyler, 2017-02-15 18:08:14]

The CQ bit was checked by dschuyler@chromium.org

[commit-bot: I haz the power, 2017-02-15 18:08:39]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-15 19:18:17]

CQ is committing da patch.

Bot data: {"patchset_id": 400001, "attempt_start_ts": 1487182094575800,
"parent_rev": "6ac78638dbd719015453216fb4c9fa8185bc885f", "commit_rev":
"8f21fb41278cc936a74fa33148ca01d394dd54a9"}

[commit-bot: I haz the power, 2017-02-15 19:18:59]

Description was changed from

==========
Revert of [i18n] chromeos login i18n-content to $i18n{} (patchset #4 id:80001 of
https://codereview.chromium.org/2626123002/ )

Reason for revert:
crbug/691904 reports that when changing the language, the pages are not redrawn
in the newly selected language. This CL is not critical to get into M-57 so I'm
reverting it to get a M-57 working asap. I can look into it further for a later
milestone.

Original issue's description:
> [i18n] chromeos login i18n-content to $i18n{}
> 
> This is a semi-mechanical change to convert i18n-content to $i18n{}. The
> Non-mechancal changes are some formatting adjustments.
> 
> BUG=677338
> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
> 
> Review-Url: https://codereview.chromium.org/2626123002
> Cr-Commit-Position: refs/heads/master@{#443327}
> Committed:
https://chromium.googlesource.com/chromium/src/+/9dfcececdc896dd4be4d516de61d...

TBR=tommycli@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=691904
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Revert of [i18n] chromeos login i18n-content to $i18n{} (patchset #4 id:80001 of
https://codereview.chromium.org/2626123002/ )

Reason for revert:
crbug/691904 reports that when changing the language, the pages are not redrawn
in the newly selected language. This CL is not critical to get into M-57 so I'm
reverting it to get a M-57 working asap. I can look into it further for a later
milestone.

Original issue's description:
> [i18n] chromeos login i18n-content to $i18n{}
> 
> This is a semi-mechanical change to convert i18n-content to $i18n{}. The
> Non-mechancal changes are some formatting adjustments.
> 
> BUG=677338
> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
> 
> Review-Url: https://codereview.chromium.org/2626123002
> Cr-Commit-Position: refs/heads/master@{#443327}
> Committed:
https://chromium.googlesource.com/chromium/src/+/9dfcececdc896dd4be4d516de61d...

TBR=tommycli@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=691904
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2694353002
Cr-Commit-Position: refs/heads/master@{#450762}
Committed:
https://chromium.googlesource.com/chromium/src/+/8f21fb41278cc936a74fa33148ca...
==========

[commit-bot: I haz the power, 2017-02-15 19:19:01]

Committed patchset #3 (id:400001) as
https://chromium.googlesource.com/chromium/src/+/8f21fb41278cc936a74fa33148ca...