Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(146)

Issue 2688413008: Revert of [i18n] chromeos login i18n-content to $i18n{} (Closed)

Created:
3 years, 10 months ago by dschuyler
Modified:
3 years, 10 months ago
Reviewers:
CC:
chromium-reviews, alemate+watch_chromium.org, dtseng+watch_chromium.org, aboxhall+watch_chromium.org, nektar+watch_chromium.org, achuith+watch_chromium.org, yuzo+watch_chromium.org, je_julie, pam+watch_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org, dmazzoni+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [i18n] chromeos login i18n-content to $i18n{} (patchset #4 id:80001 of https://codereview.chromium.org/2626123002/ ) Reason for revert: crbug/691904 reports that when changing the language, the pages are not redrawn in the newly selected language. This CL is not critical to get into M-57 so I'm reverting it to get a M-57 working asap. I can look into it further for a later milestone. Original issue's description: > [i18n] chromeos login i18n-content to $i18n{} > > This is a semi-mechanical change to convert i18n-content to $i18n{}. The > Non-mechancal changes are some formatting adjustments. > > BUG=677338 > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation > > Review-Url: https://codereview.chromium.org/2626123002 > Cr-Commit-Position: refs/heads/master@{#443327} > Committed: https://chromium.googlesource.com/chromium/src/+/9dfcececdc896dd4be4d516de61d7f8bceebea99 TBR=tommycli@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=677338

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+454 lines, -416 lines) Patch
M chrome/browser/resources/chromeos/login/accessibility_menu.css View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/chromeos/login/accessibility_menu.html View 1 chunk +10 lines, -10 lines 0 comments Download
M chrome/browser/resources/chromeos/login/api_keys_notice.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/chromeos/login/controller-pairing-screen.html View 3 chunks +67 lines, -61 lines 0 comments Download
M chrome/browser/resources/chromeos/login/controller-pairing-screen.js View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/chromeos/login/controller_pairing_page.css View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/chromeos/login/demo_user_login.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/chromeos/login/gaia_buttons.html View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/chromeos/login/gaia_buttons.js View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/chromeos/login/gaia_card.html View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/chromeos/login/gaia_header.html View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/chromeos/login/gaia_input.css View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/chromeos/login/gaia_input.html View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/chromeos/login/gaia_input.js View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/chromeos/login/gaia_input_form.html View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/chromeos/login/gaia_password_changed.html View 4 chunks +11 lines, -8 lines 0 comments Download
M chrome/browser/resources/chromeos/login/header_bar.html View 3 chunks +16 lines, -15 lines 0 comments Download
M chrome/browser/resources/chromeos/login/host-pairing-screen.html View 3 chunks +28 lines, -21 lines 0 comments Download
M chrome/browser/resources/chromeos/login/html-echo.html View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/chromeos/login/lock.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/chromeos/login/login.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/chromeos/login/offline_gaia.html View 3 chunks +7 lines, -6 lines 0 comments Download
M chrome/browser/resources/chromeos/login/oobe.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/chromeos/login/oobe_buttons.html View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/resources/chromeos/login/oobe_eula.html View 2 chunks +10 lines, -9 lines 0 comments Download
M chrome/browser/resources/chromeos/login/oobe_hid_detection.html View 5 chunks +11 lines, -10 lines 0 comments Download
M chrome/browser/resources/chromeos/login/oobe_screen_auto_enrollment_check.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/chromeos/login/oobe_screen_autolaunch.html View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/resources/chromeos/login/oobe_screen_enable_debugging.html View 2 chunks +19 lines, -19 lines 0 comments Download
M chrome/browser/resources/chromeos/login/oobe_screen_enable_kiosk.html View 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/browser/resources/chromeos/login/oobe_screen_eula.html View 2 chunks +9 lines, -10 lines 0 comments Download
M chrome/browser/resources/chromeos/login/oobe_screen_eula_installation_settings_overlay.html View 1 chunk +8 lines, -7 lines 0 comments Download
M chrome/browser/resources/chromeos/login/oobe_screen_hid_detection.html View 4 chunks +18 lines, -16 lines 0 comments Download
M chrome/browser/resources/chromeos/login/oobe_screen_network.html View 2 chunks +14 lines, -19 lines 0 comments Download
M chrome/browser/resources/chromeos/login/oobe_screen_oauth_enrollment.html View 3 chunks +12 lines, -14 lines 0 comments Download
M chrome/browser/resources/chromeos/login/oobe_screen_reset.html View 1 chunk +16 lines, -15 lines 0 comments Download
M chrome/browser/resources/chromeos/login/oobe_screen_reset_confirmation_overlay.html View 1 chunk +13 lines, -8 lines 0 comments Download
M chrome/browser/resources/chromeos/login/oobe_screen_terms_of_service.html View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/resources/chromeos/login/oobe_screen_update.html View 2 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/resources/chromeos/login/oobe_screen_user_image.html View 2 chunks +3 lines, -4 lines 0 comments Download
M chrome/browser/resources/chromeos/login/oobe_update.html View 2 chunks +6 lines, -8 lines 0 comments Download
M chrome/browser/resources/chromeos/login/oobe_welcome.html View 7 chunks +40 lines, -30 lines 0 comments Download
M chrome/browser/resources/chromeos/login/oobe_welcome_dialog.html View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/resources/chromeos/login/saml_confirm_password.html View 1 chunk +6 lines, -5 lines 0 comments Download
M chrome/browser/resources/chromeos/login/saml_interstitial.html View 2 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/resources/chromeos/login/screen_app_launch_splash.html View 1 chunk +4 lines, -6 lines 0 comments Download
M chrome/browser/resources/chromeos/login/screen_arc_terms_of_service.html View 4 chunks +10 lines, -9 lines 0 comments Download
M chrome/browser/resources/chromeos/login/screen_device_disabled.html View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/resources/chromeos/login/screen_error_message.html View 3 chunks +34 lines, -34 lines 0 comments Download
M chrome/browser/resources/chromeos/login/screen_supervised_user_creation.html View 5 chunks +22 lines, -27 lines 0 comments Download
M chrome/browser/resources/chromeos/login/screen_tpm_error.html View 1 chunk +4 lines, -6 lines 0 comments Download
M chrome/browser/resources/chromeos/login/screen_wrong_hwid.html View 1 chunk +6 lines, -5 lines 0 comments Download
M chrome/browser/resources/chromeos/login/unrecoverable_cryptohome_error_card.html View 1 chunk +4 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (4 generated)
dschuyler
Created Revert of [i18n] chromeos login i18n-content to $i18n{}
3 years, 10 months ago (2017-02-14 22:05:33 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2688413008/1
3 years, 10 months ago (2017-02-14 22:06:13 UTC) #3
commit-bot: I haz the power
3 years, 10 months ago (2017-02-14 22:10:22 UTC) #5
Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)

Powered by Google App Engine
This is Rietveld 408576698