EnumTraits for base::i18n::TextDirection.

EnumTraits for base::i18n::TextDirection.

Moves EnumTraits for base::i18n::TextDirection from autofill_types.mojom
to mojo/common/rtl.mojom so IME can also use it.

This also removes TEXT_DIRECTION_NUM_DIRECTIONS and introduces 
TEXT_DIRECTION_MAX = LEFT_TO_RIGHT, to avoid having an extra unnecessary
case in switch statements on TextDirection.

BUG=NONE

Review-Url: https://codereview.chromium.org/2626093004
Cr-Commit-Position: refs/heads/master@{#443736}
Committed: https://chromium.googlesource.com/chromium/src/+/6c5bf8fac0cd765eb4152cb3b7c8f080d02bce2f

[Hadi, 2017-01-12 19:56:51]

Description was changed from

==========
EnumTraits for base::i18n::TextDirection.

BUG=NONE
==========

to

==========
EnumTraits for base::i18n::TextDirection.

Moves EnumTraits for base::i18n::TextDirection from autofill_types.mojom
to mojo/common/rtl.mojom so IME can also use it.

BUG=NONE
==========

[Hadi, 2017-01-12 20:02:32]

moshayedi@chromium.org changed reviewers:
+ mathp@chromium.org, tsepez@chromium.org, yzshen@chromium.org

[Hadi, 2017-01-12 20:02:32]

mathp@ please review components/autofill/*.
yzshen@ please review mojo/*.
tsepez@ please review *.mojom and *_struct_traits.*

Thanks

[Hadi, 2017-01-12 20:02:42]

The CQ bit was checked by moshayedi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-12 20:04:30]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-12 20:09:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-12 20:09:54]

Dry run: Try jobs failed on following builders:
  android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Hadi, 2017-01-12 20:51:59]

The CQ bit was checked by moshayedi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-12 20:52:50]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Hadi, 2017-01-12 21:24:14]

The CQ bit was checked by moshayedi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-12 21:24:55]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Hadi, 2017-01-12 21:28:16]

Description was changed from

==========
EnumTraits for base::i18n::TextDirection.

Moves EnumTraits for base::i18n::TextDirection from autofill_types.mojom
to mojo/common/rtl.mojom so IME can also use it.

BUG=NONE
==========

to

==========
EnumTraits for base::i18n::TextDirection.

Moves EnumTraits for base::i18n::TextDirection from autofill_types.mojom
to mojo/common/rtl.mojom so IME can also use it.

This also removes TEXT_DIRECTION_NUM_DIRECTIONS and introduces 
TEXT_DIRECTION_MAX = LEFT_TO_RIGHT, to avoid having an extra unnecessary
case in switch statements on TextDirection.

BUG=NONE
==========

[commit-bot: I haz the power, 2017-01-12 21:53:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-12 21:53:38]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[Hadi, 2017-01-12 21:59:11]

The CQ bit was checked by moshayedi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-12 22:00:01]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Hadi, 2017-01-12 22:39:31]

moshayedi@chromium.org changed reviewers:
+ jshin@chromium.org

[Hadi, 2017-01-12 22:39:32]

Adding jshin@ for base/i18n/rtl.h.

Thanks.

[Hadi, 2017-01-12 22:57:06]

moshayedi@chromium.org changed reviewers:
+ dcheng@chromium.org

[Hadi, 2017-01-12 22:57:06]

Since jshin@ seems to be OOO, adding dcheng@ for base/*.

Thanks.

[dcheng, 2017-01-12 23:04:12]

mojo, struct traits, and base lgtm

[Tom Sepez, 2017-01-12 23:30:38]

mojom LGTM

[commit-bot: I haz the power, 2017-01-12 23:48:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-12 23:48:30]

Dry run: This issue passed the CQ dry run.

[Mathieu, 2017-01-13 00:41:47]

autofill lgtm, nice!

[yzshen1, 2017-01-13 21:00:45]

LGTM with one comment

https://codereview.chromium.org/2626093004/diff/80001/mojo/common/rtl.mojom
File mojo/common/rtl.mojom (right):

https://codereview.chromium.org/2626093004/diff/80001/mojo/common/rtl.mojom#n...
mojo/common/rtl.mojom:1: // Copyright 2017 The Chromium Authors. All rights
reserved.
Could we make the name of this file more specific, say text_direction.mojom?
(Unless there is plan to introduce more rtl-related types that are suitable to
be in the same file.)

[Hadi, 2017-01-13 22:07:34]

https://codereview.chromium.org/2626093004/diff/80001/mojo/common/rtl.mojom
File mojo/common/rtl.mojom (right):

https://codereview.chromium.org/2626093004/diff/80001/mojo/common/rtl.mojom#n...
mojo/common/rtl.mojom:1: // Copyright 2017 The Chromium Authors. All rights
reserved.
On 2017/01/13 21:00:45, yzshen1 wrote:
> Could we make the name of this file more specific, say text_direction.mojom?
> (Unless there is plan to introduce more rtl-related types that are suitable to
> be in the same file.)

Thanks for feedback. Done.

[Hadi, 2017-01-13 22:07:39]

The CQ bit was checked by moshayedi@chromium.org

[Hadi, 2017-01-13 22:07:40]

The patchset sent to the CQ was uploaded after l-g-t-m from mathp@chromium.org,
tsepez@chromium.org, yzshen@chromium.org, dcheng@chromium.org
Link to the patchset: https://codereview.chromium.org/2626093004/#ps100001
(title: "Addressed feedback.")

[commit-bot: I haz the power, 2017-01-13 22:08:22]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jungshik at Google, 2017-01-13 23:10:15]

LGTM

[commit-bot: I haz the power, 2017-01-14 00:08:24]

CQ is committing da patch.

Bot data: {"patchset_id": 100001, "attempt_start_ts": 1484345259983760,
"parent_rev": "f14c7a220a083a7fd6870a10f35fdcf9a8c0b01b", "commit_rev":
"6c5bf8fac0cd765eb4152cb3b7c8f080d02bce2f"}

[commit-bot: I haz the power, 2017-01-14 00:09:00]

Description was changed from

==========
EnumTraits for base::i18n::TextDirection.

Moves EnumTraits for base::i18n::TextDirection from autofill_types.mojom
to mojo/common/rtl.mojom so IME can also use it.

This also removes TEXT_DIRECTION_NUM_DIRECTIONS and introduces 
TEXT_DIRECTION_MAX = LEFT_TO_RIGHT, to avoid having an extra unnecessary
case in switch statements on TextDirection.

BUG=NONE
==========

to

==========
EnumTraits for base::i18n::TextDirection.

Moves EnumTraits for base::i18n::TextDirection from autofill_types.mojom
to mojo/common/rtl.mojom so IME can also use it.

This also removes TEXT_DIRECTION_NUM_DIRECTIONS and introduces 
TEXT_DIRECTION_MAX = LEFT_TO_RIGHT, to avoid having an extra unnecessary
case in switch statements on TextDirection.

BUG=NONE

Review-Url: https://codereview.chromium.org/2626093004
Cr-Commit-Position: refs/heads/master@{#443736}
Committed:
https://chromium.googlesource.com/chromium/src/+/6c5bf8fac0cd765eb4152cb3b7c8...
==========

[commit-bot: I haz the power, 2017-01-14 00:09:02]

Committed patchset #6 (id:100001) as
https://chromium.googlesource.com/chromium/src/+/6c5bf8fac0cd765eb4152cb3b7c8...