Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(702)

Unified Diff: components/autofill/content/common/autofill_types.mojom

Issue 2626093004: EnumTraits for base::i18n::TextDirection. (Closed)
Patch Set: Addressed feedback. Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/autofill/content/common/autofill_types.mojom
diff --git a/components/autofill/content/common/autofill_types.mojom b/components/autofill/content/common/autofill_types.mojom
index 3795d253e7b507f47cccb71810fd3baa57cbbe63..99303bd9be23a5704416c84bd8bd63c79057bdad 100644
--- a/components/autofill/content/common/autofill_types.mojom
+++ b/components/autofill/content/common/autofill_types.mojom
@@ -4,6 +4,7 @@
module autofill.mojom;
+import "mojo/common/text_direction.mojom";
import "mojo/common/time.mojom";
import "url/mojo/origin.mojom";
import "url/mojo/url.mojom";
@@ -21,14 +22,6 @@ enum RoleAttribute {
ROLE_ATTRIBUTE_OTHER
};
-// base::i18n::TextDirection
-enum TextDirection {
- UNKNOWN_DIRECTION = 0,
- RIGHT_TO_LEFT = 1,
- LEFT_TO_RIGHT = 2,
- TEXT_DIRECTION_NUM_DIRECTIONS = 3
-};
-
// autofill::PasswordForm::GenerationUploadStatus
enum GenerationUploadStatus {
NO_SIGNAL_SENT,
@@ -84,7 +77,7 @@ struct FormFieldData {
bool is_focusable;
bool should_autocomplete;
RoleAttribute role;
- TextDirection text_direction;
+ mojo.common.mojom.TextDirection text_direction;
array<string> option_values;
array<string> option_contents;

Powered by Google App Engine
This is Rietveld 408576698