mojo/common/rtl.mojom - Issue 2626093004: EnumTraits for base::i18n::TextDirection.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: mojo/common/rtl.mojom

Issue 2626093004: EnumTraits for base::i18n::TextDirection. (Closed)

Patch Set: Fixed compile error. Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 // Copyright 2017 The Chromium Authors. All rights reserved.
	yzshen1 2017/01/13 21:00:45 Could we make the name of this file more specific, Could we make the name of this file more specific, say text_direction.mojom? (Unless there is plan to introduce more rtl-related types that are suitable to be in the same file.) Hadi 2017/01/13 22:07:34 Thanks for feedback. Done. Show quoted text On 2017/01/13 21:00:45, yzshen1 wrote: > Could we make the name of this file more specific, say text_direction.mojom? > (Unless there is plan to introduce more rtl-related types that are suitable to > be in the same file.) Thanks for feedback. Done.
	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 module mojo.common.mojom;

	6

	7 // Corresponds to \|base::i18n::TextDirection\| in base/i18n/rtl.h

	8 enum TextDirection {

	9 UNKNOWN_DIRECTION,

	10 RIGHT_TO_LEFT,

	11 LEFT_TO_RIGHT

	12 };

OLD	NEW

« no previous file with comments | « mojo/common/common_custom_types_unittest.cc ('k') | mojo/common/rtl.typemap » ('j') | no next file with comments »