Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(220)

Unified Diff: components/autofill/content/common/autofill_types_struct_traits.cc

Issue 2626093004: EnumTraits for base::i18n::TextDirection. (Closed)
Patch Set: Addressed feedback. Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/autofill/content/common/autofill_types_struct_traits.h ('k') | mojo/common/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/autofill/content/common/autofill_types_struct_traits.cc
diff --git a/components/autofill/content/common/autofill_types_struct_traits.cc b/components/autofill/content/common/autofill_types_struct_traits.cc
index 41a5bcc7ff900af51d5024bffb022e06955c6fbd..b27f8a563a5a4b019d13bd7cd3d71332c5312383 100644
--- a/components/autofill/content/common/autofill_types_struct_traits.cc
+++ b/components/autofill/content/common/autofill_types_struct_traits.cc
@@ -6,6 +6,7 @@
#include "base/i18n/rtl.h"
#include "ipc/ipc_message_utils.h"
+#include "mojo/common/common_custom_types_struct_traits.h"
#include "url/mojo/origin_struct_traits.h"
#include "url/mojo/url_gurl_struct_traits.h"
@@ -83,48 +84,6 @@ bool EnumTraits<mojom::RoleAttribute, FormFieldData::RoleAttribute>::FromMojom(
}
// static
-mojom::TextDirection
-EnumTraits<mojom::TextDirection, base::i18n::TextDirection>::ToMojom(
- base::i18n::TextDirection input) {
- switch (input) {
- case base::i18n::TextDirection::UNKNOWN_DIRECTION:
- return mojom::TextDirection::UNKNOWN_DIRECTION;
- case base::i18n::TextDirection::RIGHT_TO_LEFT:
- return mojom::TextDirection::RIGHT_TO_LEFT;
- case base::i18n::TextDirection::LEFT_TO_RIGHT:
- return mojom::TextDirection::LEFT_TO_RIGHT;
- case base::i18n::TextDirection::TEXT_DIRECTION_NUM_DIRECTIONS:
- return mojom::TextDirection::TEXT_DIRECTION_NUM_DIRECTIONS;
- }
-
- NOTREACHED();
- return mojom::TextDirection::UNKNOWN_DIRECTION;
-}
-
-// static
-bool EnumTraits<mojom::TextDirection, base::i18n::TextDirection>::FromMojom(
- mojom::TextDirection input,
- base::i18n::TextDirection* output) {
- switch (input) {
- case mojom::TextDirection::UNKNOWN_DIRECTION:
- *output = base::i18n::TextDirection::UNKNOWN_DIRECTION;
- return true;
- case mojom::TextDirection::RIGHT_TO_LEFT:
- *output = base::i18n::TextDirection::RIGHT_TO_LEFT;
- return true;
- case mojom::TextDirection::LEFT_TO_RIGHT:
- *output = base::i18n::TextDirection::LEFT_TO_RIGHT;
- return true;
- case mojom::TextDirection::TEXT_DIRECTION_NUM_DIRECTIONS:
- *output = base::i18n::TextDirection::TEXT_DIRECTION_NUM_DIRECTIONS;
- return true;
- }
-
- NOTREACHED();
- return false;
-}
-
-// static
mojom::GenerationUploadStatus EnumTraits<mojom::GenerationUploadStatus,
PasswordForm::GenerationUploadStatus>::
ToMojom(PasswordForm::GenerationUploadStatus input) {
« no previous file with comments | « components/autofill/content/common/autofill_types_struct_traits.h ('k') | mojo/common/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698