IME for Mus: Send TextInputClient information to IMEDriver.

IME for Mus: Send TextInputClient information to IMEDriver.

Client sends type, mode, direction, flags, and caret bounds to IMEDriver 
when initializing a session. It can update type and caret bounds later
using methods in InputMethod.

Almost all other NOTIMPLEMENED() functions in RemoteTextInputClient are
used solely by InputMethodChromeOS::OnCaretBoundsChanged() or its
callees, which we might be able to avoid implementing in the IMEDriver
side and handle in the client side. So we don't touch them in this CL
and leave them to other CLs.

BUG=631527
Review-Url: https://codereview.chromium.org/2626983003
Cr-Commit-Position: refs/heads/master@{#443929}
Committed: https://chromium.googlesource.com/chromium/src/+/0869ab12cefea5628c54151869c88d8a21a78577

[Hadi, 2017-01-13 16:51:45]

The CQ bit was checked by moshayedi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-13 16:52:16]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-13 17:40:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-13 17:40:16]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Hadi, 2017-01-13 18:37:59]

Description was changed from

==========
IME for Mus: Send TextInputClient information to IMEDriver.

BUG=631527
==========

to

==========
IME for Mus: Send TextInputClient information to IMEDriver.

Client sends type, mode, direction, flags, and caret bounds to IMEDriver 
when initializing a session. It can update type and caret bounds later
using methods in InputMethod.

Almost all other NOTIMPLEMENED() functions in RemoteTextInputClient are
used solely by InputMethodChromeOS::OnCaretBoundsChanged() or its
callees, which we might be able to avoid implementing in the IMEDriver
side and handle in the client side. So we don't touch them in this CL
and leave them to other CLs.

BUG=631527
==========

[Hadi, 2017-01-13 18:38:53]

The CQ bit was checked by moshayedi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-13 18:39:19]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Hadi, 2017-01-13 18:42:38]

moshayedi@chromium.org changed reviewers:
+ sky@chromium.org, tsepez@chromium.org

[Hadi, 2017-01-13 18:42:39]

sky@ please take a look.
tsepez@ please review ime.mojom.

I couldn't think a way to write meaningful automated tests for changes in this
CL. We may be able to have some tests when Input Method extension support is
complete.

Our immediate use for this CL will be implementing candidate popups which need
the
caret bounds.

Thanks.

[commit-bot: I haz the power, 2017-01-13 19:39:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-13 19:39:09]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[sky, 2017-01-13 20:32:42]

https://codereview.chromium.org/2626983003/diff/60001/chrome/browser/ui/views...
File chrome/browser/ui/views/ime_driver/remote_text_input_client.h (right):

https://codereview.chromium.org/2626983003/diff/60001/chrome/browser/ui/views...
chrome/browser/ui/views/ime_driver/remote_text_input_client.h:16: explicit
RemoteTextInputClient(
remove explicit

https://codereview.chromium.org/2626983003/diff/60001/services/ui/public/inte...
File services/ui/public/interfaces/ime/ime.mojom (right):

https://codereview.chromium.org/2626983003/diff/60001/services/ui/public/inte...
services/ui/public/interfaces/ime/ime.mojom:116: struct
TextInputClientInformation {
Information -> Data or Details?

https://codereview.chromium.org/2626983003/diff/60001/services/ui/public/inte...
services/ui/public/interfaces/ime/ime.mojom:121: gfx.mojom.Rect caret_bounds;
Would it make sense to move TextInputClient and InputMethod& into here? That way
StartSession becomes StartSession(int session_id, StartSessionDetails)

[Tom Sepez, 2017-01-13 21:07:27]

mojom itself LGTM

[Hadi, 2017-01-13 21:47:53]

https://codereview.chromium.org/2626983003/diff/60001/chrome/browser/ui/views...
File chrome/browser/ui/views/ime_driver/remote_text_input_client.h (right):

https://codereview.chromium.org/2626983003/diff/60001/chrome/browser/ui/views...
chrome/browser/ui/views/ime_driver/remote_text_input_client.h:16: explicit
RemoteTextInputClient(
On 2017/01/13 20:32:41, sky wrote:
> remove explicit

Done.

https://codereview.chromium.org/2626983003/diff/60001/services/ui/public/inte...
File services/ui/public/interfaces/ime/ime.mojom (right):

https://codereview.chromium.org/2626983003/diff/60001/services/ui/public/inte...
services/ui/public/interfaces/ime/ime.mojom:121: gfx.mojom.Rect caret_bounds;
On 2017/01/13 20:32:41, sky wrote:
> Would it make sense to move TextInputClient and InputMethod& into here? That
way
> StartSession becomes StartSession(int session_id, StartSessionDetails)

Yes, I think it'll make the code simpler. Done.

https://codereview.chromium.org/2626983003/diff/80001/chrome/browser/ui/views...
File chrome/browser/ui/views/ime_driver/ime_driver_mus.cc (right):

https://codereview.chromium.org/2626983003/diff/80001/chrome/browser/ui/views...
chrome/browser/ui/views/ime_driver/ime_driver_mus.cc:45:
std::unique_ptr<RemoteTextInputClient> remote_client =
We could inline this in the next statement, just defining it here to avoid very
long statements which might be more painful to read.

https://codereview.chromium.org/2626983003/diff/80001/chrome/browser/ui/views...
File chrome/browser/ui/views/ime_driver/remote_text_input_client.h (right):

https://codereview.chromium.org/2626983003/diff/80001/chrome/browser/ui/views...
chrome/browser/ui/views/ime_driver/remote_text_input_client.h:21: gfx::Rect
caret_bounds);
We need these details to initialize RemoteTextInputClient. I didn't want to pass
a StartSessionDetails here, since it contains "input_method_request" which is
irrelevant here. I didn't pass these as a struct, since creating a struct seemed
as complex as passing them in constructor. I also didn't want to introduce
setters for the ones that shouldn't change in run-time.

Since this isn't used widely, I thought this should be ok for now. If we use
this in more places, or if we need to add more details here, then we can think
of another solution.

[Hadi, 2017-01-13 22:25:26]

The CQ bit was checked by moshayedi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-13 22:26:08]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-13 23:12:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-13 23:12:35]

Dry run: Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[sky, 2017-01-13 23:45:27]

LGTM

[Hadi, 2017-01-16 15:37:05]

The CQ bit was checked by moshayedi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-16 15:37:18]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-16 16:30:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-16 16:30:42]

Dry run: Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)

[Hadi, 2017-01-16 17:50:15]

The CQ bit was checked by moshayedi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-16 17:50:35]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Hadi, 2017-01-16 18:37:15]

The CQ bit was unchecked by moshayedi@chromium.org

[Hadi, 2017-01-16 18:37:23]

The CQ bit was checked by moshayedi@chromium.org

[Hadi, 2017-01-16 18:37:23]

The patchset sent to the CQ was uploaded after l-g-t-m from tsepez@chromium.org,
sky@chromium.org
Link to the patchset: https://codereview.chromium.org/2626983003/#ps140001
(title: "fix mojo dependencies.")

[commit-bot: I haz the power, 2017-01-16 18:37:35]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-16 19:13:10]

CQ is committing da patch.

Bot data: {"patchset_id": 140001, "attempt_start_ts": 1484591843064400,
"parent_rev": "43732b2a30af9bc55935d46366132c89f6774f2e", "commit_rev":
"0869ab12cefea5628c54151869c88d8a21a78577"}

[commit-bot: I haz the power, 2017-01-16 19:13:39]

Description was changed from

==========
IME for Mus: Send TextInputClient information to IMEDriver.

Client sends type, mode, direction, flags, and caret bounds to IMEDriver 
when initializing a session. It can update type and caret bounds later
using methods in InputMethod.

Almost all other NOTIMPLEMENED() functions in RemoteTextInputClient are
used solely by InputMethodChromeOS::OnCaretBoundsChanged() or its
callees, which we might be able to avoid implementing in the IMEDriver
side and handle in the client side. So we don't touch them in this CL
and leave them to other CLs.

BUG=631527
==========

to

==========
IME for Mus: Send TextInputClient information to IMEDriver.

Client sends type, mode, direction, flags, and caret bounds to IMEDriver 
when initializing a session. It can update type and caret bounds later
using methods in InputMethod.

Almost all other NOTIMPLEMENED() functions in RemoteTextInputClient are
used solely by InputMethodChromeOS::OnCaretBoundsChanged() or its
callees, which we might be able to avoid implementing in the IMEDriver
side and handle in the client side. So we don't touch them in this CL
and leave them to other CLs.

BUG=631527

Review-Url: https://codereview.chromium.org/2626983003
Cr-Commit-Position: refs/heads/master@{#443929}
Committed:
https://chromium.googlesource.com/chromium/src/+/0869ab12cefea5628c54151869c8...
==========

[commit-bot: I haz the power, 2017-01-16 19:13:40]

Committed patchset #8 (id:140001) as
https://chromium.googlesource.com/chromium/src/+/0869ab12cefea5628c54151869c8...