Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2624283003: Revert "Add support for generic function type syntax, part 1" (TBR) (Closed)

Created:
3 years, 11 months ago by Brian Wilkerson
Modified:
3 years, 11 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Revert "Add support for generic function type syntax, part 1" Committed: https://github.com/dart-lang/sdk/commit/85b1e7abbe035577592fc6ad995ed7ea40dfcffc

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+569 lines, -1257 lines) Patch
M pkg/analysis_server/lib/src/computer/computer_highlights.dart View 1 chunk +0 lines, -13 lines 0 comments Download
M pkg/analysis_server/lib/src/computer/computer_highlights2.dart View 1 chunk +0 lines, -13 lines 0 comments Download
M pkg/analysis_server/lib/src/computer/computer_outline.dart View 5 chunks +5 lines, -5 lines 0 comments Download
M pkg/analysis_server/lib/src/services/completion/dart/label_contributor.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/analysis_server/lib/src/services/completion/dart/local_constructor_contributor.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/analysis_server/lib/src/services/completion/dart/local_declaration_visitor.dart View 3 chunks +4 lines, -4 lines 0 comments Download
M pkg/analysis_server/lib/src/services/completion/dart/local_reference_contributor.dart View 11 chunks +15 lines, -19 lines 0 comments Download
M pkg/analysis_server/lib/src/services/completion/dart/optype.dart View 3 chunks +12 lines, -12 lines 0 comments Download
M pkg/analysis_server/lib/src/services/completion/dart/type_member_contributor.dart View 5 chunks +5 lines, -5 lines 0 comments Download
M pkg/analysis_server/lib/src/services/completion/dart/utilities.dart View 4 chunks +16 lines, -21 lines 0 comments Download
M pkg/analysis_server/lib/src/services/completion/dart/variable_name_contributor.dart View 2 chunks +3 lines, -9 lines 0 comments Download
M pkg/analysis_server/lib/src/services/correction/assist_internal.dart View 3 chunks +3 lines, -5 lines 0 comments Download
M pkg/analysis_server/lib/src/services/correction/fix_internal.dart View 3 chunks +3 lines, -3 lines 0 comments Download
M pkg/analysis_server/lib/src/services/refactoring/extract_method.dart View 1 chunk +0 lines, -9 lines 0 comments Download
M pkg/analysis_server/lib/src/status/ast_writer.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/analysis_server/test/services/completion/dart/local_declaration_visitor_test.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/analyzer/lib/dart/ast/ast.dart View 27 chunks +68 lines, -202 lines 0 comments Download
M pkg/analyzer/lib/dart/ast/ast_factory.dart View 13 chunks +13 lines, -26 lines 0 comments Download
M pkg/analyzer/lib/dart/ast/resolution_map.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/lib/dart/ast/visitor.dart View 8 chunks +1 line, -55 lines 0 comments Download
M pkg/analyzer/lib/src/dart/ast/ast.dart View 39 chunks +67 lines, -290 lines 0 comments Download
M pkg/analyzer/lib/src/dart/ast/ast_factory.dart View 16 chunks +15 lines, -37 lines 0 comments Download
M pkg/analyzer/lib/src/dart/ast/resolution_map.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/lib/src/dart/ast/utilities.dart View 19 chunks +12 lines, -178 lines 0 comments Download
M pkg/analyzer/lib/src/dart/constant/evaluation.dart View 4 chunks +7 lines, -11 lines 0 comments Download
M pkg/analyzer/lib/src/generated/element_resolver.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/lib/src/generated/error_verifier.dart View 25 chunks +63 lines, -76 lines 0 comments Download
M pkg/analyzer/lib/src/generated/resolver.dart View 28 chunks +91 lines, -70 lines 0 comments Download
M pkg/analyzer/lib/src/generated/static_type_analyzer.dart View 5 chunks +19 lines, -10 lines 0 comments Download
M pkg/analyzer/lib/src/generated/testing/ast_test_factory.dart View 23 chunks +30 lines, -36 lines 0 comments Download
M pkg/analyzer/lib/src/summary/resynthesize.dart View 4 chunks +10 lines, -12 lines 0 comments Download
M pkg/analyzer/lib/src/summary/summarize_ast.dart View 5 chunks +13 lines, -10 lines 0 comments Download
M pkg/analyzer/lib/src/summary/summarize_const_expr.dart View 2 chunks +4 lines, -8 lines 0 comments Download
M pkg/analyzer/lib/src/task/strong/checker.dart View 5 chunks +7 lines, -7 lines 0 comments Download
M pkg/analyzer/test/generated/parser_test.dart View 7 chunks +10 lines, -10 lines 0 comments Download
M pkg/analyzer/test/generated/resolver_test.dart View 3 chunks +3 lines, -15 lines 0 comments Download
M pkg/analyzer/test/generated/utilities_test.dart View 13 chunks +26 lines, -28 lines 0 comments Download
M pkg/analyzer/test/src/dart/ast/utilities_test.dart View 8 chunks +25 lines, -25 lines 0 comments Download
M pkg/analyzer/test/src/task/dart_test.dart View 1 chunk +1 line, -4 lines 0 comments Download
M pkg/analyzer/tool/summary/generate.dart View 1 chunk +3 lines, -6 lines 0 comments Download
M pkg/dev_compiler/lib/src/compiler/ast_builder.dart View 3 chunks +3 lines, -3 lines 0 comments Download
M pkg/dev_compiler/lib/src/compiler/code_generator.dart View 1 chunk +1 line, -9 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Brian Wilkerson
There is an issue in linter that needs to be fixed before I can commit ...
3 years, 11 months ago (2017-01-11 21:30:35 UTC) #2
Brian Wilkerson
Committed patchset #1 (id:1) manually as 85b1e7abbe035577592fc6ad995ed7ea40dfcffc (presubmit successful).
3 years, 11 months ago (2017-01-11 21:30:56 UTC) #4
scheglov
3 years, 11 months ago (2017-01-11 21:31:10 UTC) #5
Message was sent while issue was closed. 
lgtm :-(

Powered by Google App Engine
This is Rietveld 408576698