pkg/analysis_server/lib/src/services/correction/assist_internal.dart - Issue 2624283003: Revert "Add support for generic function type syntax, part 1" (TBR)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/analysis_server/lib/src/services/correction/assist_internal.dart

Issue 2624283003: Revert "Add support for generic function type syntax, part 1" (TBR) (Closed)

Patch Set: Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « pkg/analysis_server/lib/src/services/completion/dart/variable_name_contributor.dart ('k') | pkg/analysis_server/lib/src/services/correction/fix_internal.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: pkg/analysis_server/lib/src/services/correction/assist_internal.dart

diff --git a/pkg/analysis_server/lib/src/services/correction/assist_internal.dart b/pkg/analysis_server/lib/src/services/correction/assist_internal.dart

index 27cc2cf5c3580e0d3031e52eaa4bff1b14ce0c46..ebd7ca340aa270f36b8a91471d8b1d1dd6dab5f7 100644

--- a/pkg/analysis_server/lib/src/services/correction/assist_internal.dart

+++ b/pkg/analysis_server/lib/src/services/correction/assist_internal.dart

@@ -505,9 +505,7 @@ class AssistProcessor {

getter = n;

break;

}

- if (n is SimpleIdentifier ||

- n is TypeAnnotation ||

- n is TypeArgumentList) {

+ if (n is SimpleIdentifier || n is TypeName || n is TypeArgumentList) {

continue;

}

break;

@@ -573,7 +571,7 @@ class AssistProcessor {

if (n is SimpleIdentifier ||

n is VariableDeclaration ||

n is VariableDeclarationList ||

- n is TypeAnnotation ||

+ n is TypeName ||

n is TypeArgumentList) {

continue;

}

@@ -1566,7 +1564,7 @@ class AssistProcessor {

return;

}

// we need a type

- TypeAnnotation typeNode = declarationList.type;

+ TypeName typeNode = declarationList.type;

if (typeNode == null) {

_coverageMarker();

return;