Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Unified Diff: pkg/analyzer/test/generated/resolver_test.dart

Issue 2624283003: Revert "Add support for generic function type syntax, part 1" (TBR) (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/analyzer/test/generated/parser_test.dart ('k') | pkg/analyzer/test/generated/utilities_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analyzer/test/generated/resolver_test.dart
diff --git a/pkg/analyzer/test/generated/resolver_test.dart b/pkg/analyzer/test/generated/resolver_test.dart
index a8435396ab40eeb2662021d8c8de33f11e42532e..cb97db2957e462763fd1447f900582b2facbb3da 100644
--- a/pkg/analyzer/test/generated/resolver_test.dart
+++ b/pkg/analyzer/test/generated/resolver_test.dart
@@ -410,9 +410,9 @@ class StaticTypeVerifier extends GeneralizingAstVisitor<Object> {
List<Expression> _invalidlyPropagatedExpressions = new List<Expression>();
/**
- * The TypeAnnotation nodes that were not resolved.
+ * A list containing all of the AST TypeName nodes that were not resolved.
*/
- List<TypeAnnotation> _unresolvedTypes = new List<TypeAnnotation>();
+ List<TypeName> _unresolvedTypes = new List<TypeName>();
/**
* Counter for the number of Expression nodes visited that are resolved.
@@ -442,7 +442,7 @@ class StaticTypeVerifier extends GeneralizingAstVisitor<Object> {
buffer.write(" of ");
buffer.write(_resolvedTypeCount + unresolvedTypeCount);
buffer.writeln(" type names:");
- for (TypeAnnotation identifier in _unresolvedTypes) {
+ for (TypeName identifier in _unresolvedTypes) {
buffer.write(" ");
buffer.write(identifier.toString());
buffer.write(" (");
@@ -576,21 +576,9 @@ class StaticTypeVerifier extends GeneralizingAstVisitor<Object> {
}
@override
- Object visitTypeAnnotation(TypeAnnotation node) {
- if (node.type == null) {
- _unresolvedTypes.add(node);
- } else {
- _resolvedTypeCount++;
- }
- return super.visitTypeAnnotation(node);
- }
-
- @override
Object visitTypeName(TypeName node) {
// Note: do not visit children from this node, the child SimpleIdentifier in
// TypeName (i.e. "String") does not have a static type defined.
- // TODO(brianwilkerson) Not visiting the children means that we won't catch
- // type arguments that were not resolved.
if (node.type == null) {
_unresolvedTypes.add(node);
} else {
« no previous file with comments | « pkg/analyzer/test/generated/parser_test.dart ('k') | pkg/analyzer/test/generated/utilities_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698