pkg/analysis_server/lib/src/services/completion/dart/local_declaration_visitor.dart - Issue 2624283003: Revert "Add support for generic function type syntax, part 1" (TBR)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/analysis_server/lib/src/services/completion/dart/local_declaration_visitor.dart

Issue 2624283003: Revert "Add support for generic function type syntax, part 1" (TBR) (Closed)

Patch Set: Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « pkg/analysis_server/lib/src/services/completion/dart/local_constructor_contributor.dart ('k') | pkg/analysis_server/lib/src/services/completion/dart/local_reference_contributor.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: pkg/analysis_server/lib/src/services/completion/dart/local_declaration_visitor.dart

diff --git a/pkg/analysis_server/lib/src/services/completion/dart/local_declaration_visitor.dart b/pkg/analysis_server/lib/src/services/completion/dart/local_declaration_visitor.dart

index e290304c28dda43bcddc768843e241b165349094..adf26c7ab6f3b49a889206add424688f459716e4 100644

--- a/pkg/analysis_server/lib/src/services/completion/dart/local_declaration_visitor.dart

+++ b/pkg/analysis_server/lib/src/services/completion/dart/local_declaration_visitor.dart

@@ -39,11 +39,11 @@ abstract class LocalDeclarationVisitor extends GeneralizingAstVisitor {

void declaredLabel(Label label, bool isCaseLabel);

- void declaredLocalVar(SimpleIdentifier name, TypeAnnotation type);

+ void declaredLocalVar(SimpleIdentifier name, TypeName type);

void declaredMethod(MethodDeclaration declaration);

- void declaredParam(SimpleIdentifier name, TypeAnnotation type);

+ void declaredParam(SimpleIdentifier name, TypeName type);

void declaredTopLevelVar(

VariableDeclarationList varList, VariableDeclaration varDecl);

@@ -128,7 +128,7 @@ abstract class LocalDeclarationVisitor extends GeneralizingAstVisitor {

@override

void visitForEachStatement(ForEachStatement node) {

SimpleIdentifier id;

- TypeAnnotation type;

+ TypeName type;

DeclaredIdentifier loopVar = node.loopVariable;

if (loopVar != null) {

id = loopVar.identifier;

@@ -233,7 +233,7 @@ abstract class LocalDeclarationVisitor extends GeneralizingAstVisitor {

} else if (param is NormalFormalParameter) {

normalParam = param;

}

- TypeAnnotation type = null;

+ TypeName type = null;

if (normalParam is FieldFormalParameter) {

type = normalParam.type;

} else if (normalParam is FunctionTypedFormalParameter) {