Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Unified Diff: pkg/dev_compiler/lib/src/compiler/code_generator.dart

Issue 2624283003: Revert "Add support for generic function type syntax, part 1" (TBR) (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/dev_compiler/lib/src/compiler/ast_builder.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/dev_compiler/lib/src/compiler/code_generator.dart
diff --git a/pkg/dev_compiler/lib/src/compiler/code_generator.dart b/pkg/dev_compiler/lib/src/compiler/code_generator.dart
index afabcf3a6cb464103b5cce1d8cd97a446732f367..60469c3b0640f1d3e74fe166c68b07362b77a1ca 100644
--- a/pkg/dev_compiler/lib/src/compiler/code_generator.dart
+++ b/pkg/dev_compiler/lib/src/compiler/code_generator.dart
@@ -3624,15 +3624,7 @@ class CodeGenerator extends GeneralizingAstVisitor
} else if (typeArgs != null) {
// Dynamic calls may have type arguments, even though the function types
// are not known.
- return typeArgs.arguments.map((argument) {
- if (argument is TypeName) {
- return visitTypeName(argument);
- } else {
- // TODO(brianwilkerson) Implement support for GenericFunctionType.
- throw new StateError(
- 'Cannot compile type argument of kind ${argument.runtimeType}');
- }
- }).toList(growable: false);
+ return typeArgs.arguments.map(visitTypeName).toList(growable: false);
}
return null;
}
« no previous file with comments | « pkg/dev_compiler/lib/src/compiler/ast_builder.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698