pkg/analysis_server/lib/src/services/completion/dart/type_member_contributor.dart - Issue 2624283003: Revert "Add support for generic function type syntax, part 1" (TBR)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/analysis_server/lib/src/services/completion/dart/type_member_contributor.dart

Issue 2624283003: Revert "Add support for generic function type syntax, part 1" (TBR) (Closed)

Patch Set: Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « pkg/analysis_server/lib/src/services/completion/dart/optype.dart ('k') | pkg/analysis_server/lib/src/services/completion/dart/utilities.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: pkg/analysis_server/lib/src/services/completion/dart/type_member_contributor.dart

diff --git a/pkg/analysis_server/lib/src/services/completion/dart/type_member_contributor.dart b/pkg/analysis_server/lib/src/services/completion/dart/type_member_contributor.dart

index 1921bfaa626d0f5b9bd06e8d8cdc0d6f6b765838..d535ef4b27ac57c4245c9e211a5c32a8ef261e43 100644

--- a/pkg/analysis_server/lib/src/services/completion/dart/type_member_contributor.dart

+++ b/pkg/analysis_server/lib/src/services/completion/dart/type_member_contributor.dart

@@ -161,7 +161,7 @@ class _LocalBestTypeVisitor extends LocalDeclarationVisitor {

@override

void declaredFunction(FunctionDeclaration declaration) {

if (declaration.name.name == targetName) {

- TypeAnnotation typeName = declaration.returnType;

+ TypeName typeName = declaration.returnType;

if (typeName != null) {

typeFound = typeName.type;

}

@@ -172,7 +172,7 @@ class _LocalBestTypeVisitor extends LocalDeclarationVisitor {

@override

void declaredFunctionTypeAlias(FunctionTypeAlias declaration) {

if (declaration.name.name == targetName) {

- TypeAnnotation typeName = declaration.returnType;

+ TypeName typeName = declaration.returnType;

if (typeName != null) {

typeFound = typeName.type;

}

@@ -189,7 +189,7 @@ class _LocalBestTypeVisitor extends LocalDeclarationVisitor {

}

@override

- void declaredLocalVar(SimpleIdentifier name, TypeAnnotation type) {

+ void declaredLocalVar(SimpleIdentifier name, TypeName type) {

if (name.name == targetName) {

typeFound = name.bestType;

finished();

@@ -199,7 +199,7 @@ class _LocalBestTypeVisitor extends LocalDeclarationVisitor {

@override

void declaredMethod(MethodDeclaration declaration) {

if (declaration.name.name == targetName) {

- TypeAnnotation typeName = declaration.returnType;

+ TypeName typeName = declaration.returnType;

if (typeName != null) {

typeFound = typeName.type;

}

@@ -208,7 +208,7 @@ class _LocalBestTypeVisitor extends LocalDeclarationVisitor {

}

@override

- void declaredParam(SimpleIdentifier name, TypeAnnotation type) {

+ void declaredParam(SimpleIdentifier name, TypeName type) {

if (name.name == targetName) {

// Type provided by the element in computeFull above

finished();