Remove most content from Interpolation

Remove most content from Interpolation

The majority of the data and logic in the Interpolation base class is only
required for the LegacyStyleInterpolation subclass, and is ignored or
overwritten for InvalidatableInterpolation. This patch moves this data and logic
down the hierarchy into LegacyStyleInterpolation.

As additional consequences:
- SampleInterpolation classes defined in tests inherit from
  LegacyStyleInterpolation instead of the Interpolation base class
- getCachedValueForTesting is made pure virtual, requiring a placeholder
  implementation to be added to InvalidatableInterpolation, although this is not
  called anywhere

BUG=678875
Review-Url: https://codereview.chromium.org/2619173002
Cr-Commit-Position: refs/heads/master@{#442801}
Committed: https://chromium.googlesource.com/chromium/src/+/28c3509737c9bca061e828e74ad67f8062ef16b9

[alancutter (OOO until 2018), 2017-01-09 03:35:54]

alancutter@chromium.org changed reviewers:
+ alancutter@chromium.org

[alancutter (OOO until 2018), 2017-01-09 03:35:55]

lgtm, long overdue clean up.

[suzyh_UTC10 (ex-contributor), 2017-01-09 04:04:12]

Thanks Alan! You're speedy, I hadn't even pressed the 'publish' button on this
one yet ;)

[suzyh_UTC10 (ex-contributor), 2017-01-10 22:44:04]

The CQ bit was checked by suzyh@chromium.org

[commit-bot: I haz the power, 2017-01-10 22:44:38]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-11 00:14:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-11 00:14:54]

Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[suzyh_UTC10 (ex-contributor), 2017-01-11 04:06:33]

The CQ bit was checked by suzyh@chromium.org

[commit-bot: I haz the power, 2017-01-11 04:07:11]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-11 04:38:40]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1484107593290340, "parent_rev":
"65f4db51ec74c23432addc7b43a7bb0554c75157", "commit_rev":
"28c3509737c9bca061e828e74ad67f8062ef16b9"}

[commit-bot: I haz the power, 2017-01-11 04:39:13]

Description was changed from

==========
Remove most content from Interpolation

The majority of the data and logic in the Interpolation base class is only
required for the LegacyStyleInterpolation subclass, and is ignored or
overwritten for InvalidatableInterpolation. This patch moves this data and logic
down the hierarchy into LegacyStyleInterpolation.

As additional consequences:
- SampleInterpolation classes defined in tests inherit from
  LegacyStyleInterpolation instead of the Interpolation base class
- getCachedValueForTesting is made pure virtual, requiring a placeholder
  implementation to be added to InvalidatableInterpolation, although this is not
  called anywhere

BUG=678875
==========

to

==========
Remove most content from Interpolation

The majority of the data and logic in the Interpolation base class is only
required for the LegacyStyleInterpolation subclass, and is ignored or
overwritten for InvalidatableInterpolation. This patch moves this data and logic
down the hierarchy into LegacyStyleInterpolation.

As additional consequences:
- SampleInterpolation classes defined in tests inherit from
  LegacyStyleInterpolation instead of the Interpolation base class
- getCachedValueForTesting is made pure virtual, requiring a placeholder
  implementation to be added to InvalidatableInterpolation, although this is not
  called anywhere

BUG=678875

Review-Url: https://codereview.chromium.org/2619173002
Cr-Commit-Position: refs/heads/master@{#442801}
Committed:
https://chromium.googlesource.com/chromium/src/+/28c3509737c9bca061e828e74ad6...
==========

[commit-bot: I haz the power, 2017-01-11 04:39:15]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/28c3509737c9bca061e828e74ad6...